Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (max197) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-10-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
19eae13a 62f5e95d

+2 -4
+2 -4
drivers/hwmon/max197.c
··· 312 312 return ret; 313 313 } 314 314 315 - static int max197_remove(struct platform_device *pdev) 315 + static void max197_remove(struct platform_device *pdev) 316 316 { 317 317 struct max197_data *data = platform_get_drvdata(pdev); 318 318 319 319 hwmon_device_unregister(data->hwmon_dev); 320 320 sysfs_remove_group(&pdev->dev.kobj, &max197_sysfs_group); 321 - 322 - return 0; 323 321 } 324 322 325 323 static const struct platform_device_id max197_device_ids[] = { ··· 332 334 .name = "max197", 333 335 }, 334 336 .probe = max197_probe, 335 - .remove = max197_remove, 337 + .remove_new = max197_remove, 336 338 .id_table = max197_device_ids, 337 339 }; 338 340 module_platform_driver(max197_driver);