Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: sm712fb: set error code in probe

If smtcfb_pci_probe() does not detect a valid chip it cleans up
everything and returns 0. This can result in various bad things later.
The patch sets the error code on the corresponding path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200706155328.8396-1-novikov@ispras.ru

authored by

Evgeny Novikov and committed by
Bartlomiej Zolnierkiewicz
19e55a87 80a00e90

+1 -1
+1 -1
drivers/video/fbdev/sm712fb.c
··· 1616 1616 default: 1617 1617 dev_err(&pdev->dev, 1618 1618 "No valid Silicon Motion display chip was detected!\n"); 1619 - 1619 + err = -ENODEV; 1620 1620 goto failed_fb; 1621 1621 } 1622 1622