Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: mpc8xxx: latch GPIOs state on module load when configured as output

Qoriq and related devices allow reading out state of GPIO set as output.
However, currently on driver's init, all outputs are configured as driven
low. So, any changes to GPIO confiuration will drive all pins (configured
as output) as output-low.
This patch latches state of output GPIOs before any GPIO configuration
takes place. This preserves any output settings done prior to loading
the driver (for example, by u-boot).

Signed-off-by: Michal Smulski <michal.smulski@ooma.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Michal Smulski and committed by
Bartosz Golaszewski
19b60f84 61c65a8b

+5 -1
+5 -1
drivers/gpio/gpio-mpc8xxx.c
··· 375 375 if (of_device_is_compatible(np, "fsl,qoriq-gpio") || 376 376 of_device_is_compatible(np, "fsl,ls1028a-gpio") || 377 377 of_device_is_compatible(np, "fsl,ls1088a-gpio") || 378 - is_acpi_node(fwnode)) 378 + is_acpi_node(fwnode)) { 379 379 gc->write_reg(mpc8xxx_gc->regs + GPIO_IBE, 0xffffffff); 380 + /* Also, latch state of GPIOs configured as output by bootloader. */ 381 + gc->bgpio_data = gc->read_reg(mpc8xxx_gc->regs + GPIO_DAT) & 382 + gc->read_reg(mpc8xxx_gc->regs + GPIO_DIR); 383 + } 380 384 381 385 ret = devm_gpiochip_add_data(&pdev->dev, gc, mpc8xxx_gc); 382 386 if (ret) {