Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/bridge: analogix_dp: return error if transfer none byte

Reference from drm_dp_aux description (about transfer):
Upon success, the implementation should return the number of payload bytes
that were transferred, or a negative error-code on failure. Helpers
propagate errors from the .transfer() function, with the exception of
the -EBUSY error, which causes a transaction to be retried. On a short,
helpers will return -EPROTO to make it simpler to check for failure.

The analogix_dp_transfer will return num_transferred, but if there is none
byte been transferred, the return value will be 0, which means success, we
should return error-code if transfer none byte.

for (retry = 0; retry < 32; retry++) {
err = aux->transfer(aux, &msg);
if (err < 0) {
if (err == -EBUSY)
continue;

goto unlock;
}
}

Cc: zain wang <wzz@rock-chips.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: Archit Taneja <architt@codeaurora.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1479255219-7243-1-git-send-email-jay.xu@rock-chips.com

authored by

Jianqun Xu and committed by
Archit Taneja
19423ba7 b9876d50

+1 -1
+1 -1
drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
··· 1162 1162 (msg->request & ~DP_AUX_I2C_MOT) == DP_AUX_NATIVE_READ) 1163 1163 msg->reply = DP_AUX_NATIVE_REPLY_ACK; 1164 1164 1165 - return num_transferred; 1165 + return num_transferred > 0 ? num_transferred : -EBUSY; 1166 1166 }