Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

include/linux/bcd.h: provide bcd_is_valid() helper

bcd2bin(0x0A) happily returns 10, despite this being an invalid BCD
value. RTC drivers converting possibly corrupted BCD timestamps might
want to validate their input before calling bcd2bin().

Provide a macro to do so. Unlike bcd2bin and bin2bcd, out-of-line
versions are not implemented. Should the macro experience enough use,
this can be retrofitted.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/r/20221123095527.2771434-2-s.hauer@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Ahmad Fatoum and committed by
Alexandre Belloni
19409796 04596d4b

+4
+4
include/linux/bcd.h
··· 14 14 const_bin2bcd(x) : \ 15 15 _bin2bcd(x)) 16 16 17 + #define bcd_is_valid(x) \ 18 + const_bcd_is_valid(x) 19 + 17 20 #define const_bcd2bin(x) (((x) & 0x0f) + ((x) >> 4) * 10) 18 21 #define const_bin2bcd(x) ((((x) / 10) << 4) + (x) % 10) 22 + #define const_bcd_is_valid(x) (((x) & 0x0f) < 10 && ((x) >> 4) < 10) 19 23 20 24 unsigned _bcd2bin(unsigned char val) __attribute_const__; 21 25 unsigned char _bin2bcd(unsigned val) __attribute_const__;