cifs: fix potential null pointer use in destroy_workqueue in init_cifs error path

Dan Carpenter reported a Smack static checker warning:
fs/smb/client/cifsfs.c:1981 init_cifs()
error: we previously assumed 'serverclose_wq' could be null (see line 1895)

The patch which introduced the serverclose workqueue used the wrong
oredering in error paths in init_cifs() for freeing it on errors.

Fixes: 173217bd7336 ("smb3: retrying on failed server close")
Cc: stable@vger.kernel.org
Cc: Ritvik Budhiraja <rbudhiraja@microsoft.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: David Howells <dhowell@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

+4 -4
+4 -4
fs/smb/client/cifsfs.c
··· 1894 1894 WQ_FREEZABLE|WQ_MEM_RECLAIM, 0); 1895 1895 if (!serverclose_wq) { 1896 1896 rc = -ENOMEM; 1897 - goto out_destroy_serverclose_wq; 1897 + goto out_destroy_deferredclose_wq; 1898 1898 } 1899 1899 1900 1900 rc = cifs_init_inodecache(); 1901 1901 if (rc) 1902 - goto out_destroy_deferredclose_wq; 1902 + goto out_destroy_serverclose_wq; 1903 1903 1904 1904 rc = cifs_init_netfs(); 1905 1905 if (rc) ··· 1967 1967 cifs_destroy_netfs(); 1968 1968 out_destroy_inodecache: 1969 1969 cifs_destroy_inodecache(); 1970 + out_destroy_serverclose_wq: 1971 + destroy_workqueue(serverclose_wq); 1970 1972 out_destroy_deferredclose_wq: 1971 1973 destroy_workqueue(deferredclose_wq); 1972 1974 out_destroy_cifsoplockd_wq: ··· 1979 1977 destroy_workqueue(decrypt_wq); 1980 1978 out_destroy_cifsiod_wq: 1981 1979 destroy_workqueue(cifsiod_wq); 1982 - out_destroy_serverclose_wq: 1983 - destroy_workqueue(serverclose_wq); 1984 1980 out_clean_proc: 1985 1981 cifs_proc_clean(); 1986 1982 return rc;