Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rfkill: remove/inline __rfkill_set_hw_state

__rfkill_set_hw_state() is only one used in rfkill_set_hw_state(), and
none of them are long or complicated, so merging the two makes the code
easier to read.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

authored by

João Paulo Rechi Vita and committed by
Johannes Berg
1926e260 f3e7fae2

+15 -26
+15 -26
net/rfkill/core.c
··· 235 235 rfkill_send_events(rfkill, RFKILL_OP_CHANGE); 236 236 } 237 237 238 - static bool __rfkill_set_hw_state(struct rfkill *rfkill, 239 - bool blocked, bool *change) 240 - { 241 - unsigned long flags; 242 - bool prev, any; 243 - 244 - BUG_ON(!rfkill); 245 - 246 - spin_lock_irqsave(&rfkill->lock, flags); 247 - prev = !!(rfkill->state & RFKILL_BLOCK_HW); 248 - if (blocked) 249 - rfkill->state |= RFKILL_BLOCK_HW; 250 - else 251 - rfkill->state &= ~RFKILL_BLOCK_HW; 252 - *change = prev != blocked; 253 - any = !!(rfkill->state & RFKILL_BLOCK_ANY); 254 - spin_unlock_irqrestore(&rfkill->lock, flags); 255 - 256 - rfkill_led_trigger_event(rfkill); 257 - 258 - return any; 259 - } 260 - 261 238 /** 262 239 * rfkill_set_block - wrapper for set_block method 263 240 * ··· 459 482 460 483 bool rfkill_set_hw_state(struct rfkill *rfkill, bool blocked) 461 484 { 462 - bool ret, change; 485 + unsigned long flags; 486 + bool ret, prev; 463 487 464 - ret = __rfkill_set_hw_state(rfkill, blocked, &change); 488 + BUG_ON(!rfkill); 489 + 490 + spin_lock_irqsave(&rfkill->lock, flags); 491 + prev = !!(rfkill->state & RFKILL_BLOCK_HW); 492 + if (blocked) 493 + rfkill->state |= RFKILL_BLOCK_HW; 494 + else 495 + rfkill->state &= ~RFKILL_BLOCK_HW; 496 + ret = !!(rfkill->state & RFKILL_BLOCK_ANY); 497 + spin_unlock_irqrestore(&rfkill->lock, flags); 498 + 499 + rfkill_led_trigger_event(rfkill); 465 500 466 501 if (!rfkill->registered) 467 502 return ret; 468 503 469 - if (change) 504 + if (prev != blocked) 470 505 schedule_work(&rfkill->uevent_work); 471 506 472 507 return ret;