Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] mb86a20s: always initialize a return value

In mb86a20s_read_status_and_stats(), when mb86a20s_read_status() fails,
the function returns the value in variable rc without initializing it
first. Fix this by propagating the error code from variable status_nr.

This bug has been found using clang and -Wsometimes-uninitialized
warning flag.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Nicolas Iooss and committed by
Mauro Carvalho Chehab
19157003 82b65714

+1
+1
drivers/media/dvb-frontends/mb86a20s.c
··· 1967 1967 if (status_nr < 0) { 1968 1968 dev_err(&state->i2c->dev, 1969 1969 "%s: Can't read frontend lock status\n", __func__); 1970 + rc = status_nr; 1970 1971 goto error; 1971 1972 } 1972 1973