Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: ds1685: actually spin forever in poweroff path

objtool reports the following warning:

drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()

Similar to commit 361c6ed6b153 ("rtc: ds1685: actually spin forever in
poweroff error path"), there's another unreachable() annotation which is
actually reachable, which we missed the first time.

Actually spin forever to be consistent with the comment and to make the
unreachable() annotation guaranteed to be unreachable.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

authored by

Josh Poimboeuf and committed by
Alexandre Belloni
19105f42 6406d96e

+1
+1
drivers/rtc/rtc-ds1685.c
··· 2211 2211 (ctrl4a | RTC_CTRL_4A_PAB)); 2212 2212 2213 2213 /* Spin ... we do not switch back to bank0. */ 2214 + while(1); 2214 2215 unreachable(); 2215 2216 } 2216 2217 }