switch vfs_mkdir() and ->mkdir() to umode_t

tjh.dev / kernel

fork atom

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

fork atom

switch vfs_mkdir() and ->mkdir() to umode_t

vfs_mkdir() gets int, but immediately drops everything that might not
fit into umode_t and that's the only caller of ->mkdir()...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 14 years ago 18bb1db3 8208a22b

+70 -70

56 changed files

expand all collapse all

Documentation

filesystems

Locking

vfs.txt

drivers

staging

pohmelfs

dir.c

vfs_inode.c

vfs_inode_dotl.c

affs

affs.h

namei.c

afs

dir.c

autofs4

root.c

bad_inode.c

btrfs

inode.c

ceph

dir.c

cifs

cifsfs.h

inode.c

coda

dir.c

configfs

dir.c

ecryptfs

inode.c

exofs

namei.c

ext2

namei.c

ext3

namei.c

ext4

namei.c

fat

namei_msdos.c

namei_vfat.c

fuse

dir.c

gfs2

inode.c

hfs

dir.c

hfsplus

dir.c

hostfs

hostfs_kern.c

hpfs

namei.c

hugetlbfs

inode.c

jffs2

dir.c

jfs

namei.c

logfs

dir.c

minix

namei.c

ncpfs

dir.c

nfs

dir.c

nilfs2

namei.c

ocfs2

dlmfs

dlmfs.c

namei.c

omfs

dir.c

ramfs

inode.c

reiserfs

namei.c

xattr.c

sysv

namei.c

ubifs

dir.c

udf

namei.c

ufs

namei.c

xfs

xfs_iops.c

include

linux

fs.h

security.h

kernel

cgroup.c

shmem.c

security

capability.c

security.c

selinux

hooks.c

+1 -1

Documentation/filesystems/Locking

reviewed

··· 43 43 int (*link) (struct dentry *,struct inode *,struct dentry *); 44 44 int (*unlink) (struct inode *,struct dentry *); 45 45 int (*symlink) (struct inode *,struct dentry *,const char *); 46 46 - int (*mkdir) (struct inode *,struct dentry *,int); 46 46 + int (*mkdir) (struct inode *,struct dentry *,umode_t); 47 47 int (*rmdir) (struct inode *,struct dentry *); 48 48 int (*mknod) (struct inode *,struct dentry *,int,dev_t); 49 49 int (*rename) (struct inode *, struct dentry *,

+1 -1

Documentation/filesystems/vfs.txt

reviewed

··· 346 346 int (*link) (struct dentry *,struct inode *,struct dentry *); 347 347 int (*unlink) (struct inode *,struct dentry *); 348 348 int (*symlink) (struct inode *,struct dentry *,const char *); 349 349 - int (*mkdir) (struct inode *,struct dentry *,int); 349 349 + int (*mkdir) (struct inode *,struct dentry *,umode_t); 350 350 int (*rmdir) (struct inode *,struct dentry *); 351 351 int (*mknod) (struct inode *,struct dentry *,int,dev_t); 352 352 int (*rename) (struct inode *, struct dentry *,

+1 -1

drivers/staging/pohmelfs/dir.c

reviewed

··· 667 667 return pohmelfs_create_entry(dir, dentry, 0, mode); 668 668 } 669 669 670 670 - static int pohmelfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 670 670 + static int pohmelfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 671 671 { 672 672 int err; 673 673

+1 -1

fs/9p/vfs_inode.c

reviewed

··· 785 785 * 786 786 */ 787 787 788 788 - static int v9fs_vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 788 788 + static int v9fs_vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 789 789 { 790 790 int err; 791 791 u32 perm;

+1 -1

fs/9p/vfs_inode_dotl.c

reviewed

··· 395 395 */ 396 396 397 397 static int v9fs_vfs_mkdir_dotl(struct inode *dir, 398 398 - struct dentry *dentry, int omode) 398 398 + struct dentry *dentry, umode_t omode) 399 399 { 400 400 int err; 401 401 struct v9fs_session_info *v9ses;

+1 -1

fs/affs/affs.h

reviewed

··· 157 157 extern struct dentry *affs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *); 158 158 extern int affs_unlink(struct inode *dir, struct dentry *dentry); 159 159 extern int affs_create(struct inode *dir, struct dentry *dentry, int mode, struct nameidata *); 160 160 - extern int affs_mkdir(struct inode *dir, struct dentry *dentry, int mode); 160 160 + extern int affs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); 161 161 extern int affs_rmdir(struct inode *dir, struct dentry *dentry); 162 162 extern int affs_link(struct dentry *olddentry, struct inode *dir, 163 163 struct dentry *dentry);

+2 -2

fs/affs/namei.c

reviewed

··· 285 285 } 286 286 287 287 int 288 288 - affs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 288 288 + affs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 289 289 { 290 290 struct inode *inode; 291 291 int error; 292 292 293 293 - pr_debug("AFFS: mkdir(%lu,\"%.*s\",0%o)\n",dir->i_ino, 293 293 + pr_debug("AFFS: mkdir(%lu,\"%.*s\",0%ho)\n",dir->i_ino, 294 294 (int)dentry->d_name.len,dentry->d_name.name,mode); 295 295 296 296 inode = affs_new_inode(dir);

+3 -3

fs/afs/dir.c

reviewed

··· 30 30 loff_t fpos, u64 ino, unsigned dtype); 31 31 static int afs_create(struct inode *dir, struct dentry *dentry, int mode, 32 32 struct nameidata *nd); 33 33 - static int afs_mkdir(struct inode *dir, struct dentry *dentry, int mode); 33 33 + static int afs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); 34 34 static int afs_rmdir(struct inode *dir, struct dentry *dentry); 35 35 static int afs_unlink(struct inode *dir, struct dentry *dentry); 36 36 static int afs_link(struct dentry *from, struct inode *dir, ··· 764 764 /* 765 765 * create a directory on an AFS filesystem 766 766 */ 767 767 - static int afs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 767 767 + static int afs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 768 768 { 769 769 struct afs_file_status status; 770 770 struct afs_callback cb; ··· 777 777 778 778 dvnode = AFS_FS_I(dir); 779 779 780 780 - _enter("{%x:%u},{%s},%o", 780 780 + _enter("{%x:%u},{%s},%ho", 781 781 dvnode->fid.vid, dvnode->fid.vnode, dentry->d_name.name, mode); 782 782 783 783 ret = -ENAMETOOLONG;

+2 -2

fs/autofs4/root.c

reviewed

··· 26 26 static int autofs4_dir_symlink(struct inode *,struct dentry *,const char *); 27 27 static int autofs4_dir_unlink(struct inode *,struct dentry *); 28 28 static int autofs4_dir_rmdir(struct inode *,struct dentry *); 29 29 - static int autofs4_dir_mkdir(struct inode *,struct dentry *,int); 29 29 + static int autofs4_dir_mkdir(struct inode *,struct dentry *,umode_t); 30 30 static long autofs4_root_ioctl(struct file *,unsigned int,unsigned long); 31 31 #ifdef CONFIG_COMPAT 32 32 static long autofs4_root_compat_ioctl(struct file *,unsigned int,unsigned long); ··· 699 699 return 0; 700 700 } 701 701 702 702 - static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, int mode) 702 702 + static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 703 703 { 704 704 struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); 705 705 struct autofs_info *ino = autofs4_dentry_ino(dentry);

+1 -1

fs/bad_inode.c

reviewed

··· 202 202 } 203 203 204 204 static int bad_inode_mkdir(struct inode *dir, struct dentry *dentry, 205 205 - int mode) 205 205 + umode_t mode) 206 206 { 207 207 return -EIO; 208 208 }

+1 -1

fs/btrfs/inode.c

reviewed

··· 4792 4792 return err; 4793 4793 } 4794 4794 4795 4795 - static int btrfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 4795 4795 + static int btrfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 4796 4796 { 4797 4797 struct inode *inode = NULL; 4798 4798 struct btrfs_trans_handle *trans;

+2 -2

fs/ceph/dir.c

reviewed

··· 753 753 return err; 754 754 } 755 755 756 756 - static int ceph_mkdir(struct inode *dir, struct dentry *dentry, int mode) 756 756 + static int ceph_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 757 757 { 758 758 struct ceph_fs_client *fsc = ceph_sb_to_client(dir->i_sb); 759 759 struct ceph_mds_client *mdsc = fsc->mdsc; ··· 767 767 dout("mksnap dir %p snap '%.*s' dn %p\n", dir, 768 768 dentry->d_name.len, dentry->d_name.name, dentry); 769 769 } else if (ceph_snap(dir) == CEPH_NOSNAP) { 770 770 - dout("mkdir dir %p dn %p mode 0%o\n", dir, dentry, mode); 770 770 + dout("mkdir dir %p dn %p mode 0%ho\n", dir, dentry, mode); 771 771 op = CEPH_MDS_OP_MKDIR; 772 772 } else { 773 773 goto out;

+1 -1

fs/cifs/cifsfs.h

reviewed

··· 51 51 extern int cifs_unlink(struct inode *dir, struct dentry *dentry); 52 52 extern int cifs_hardlink(struct dentry *, struct inode *, struct dentry *); 53 53 extern int cifs_mknod(struct inode *, struct dentry *, int, dev_t); 54 54 - extern int cifs_mkdir(struct inode *, struct dentry *, int); 54 54 + extern int cifs_mkdir(struct inode *, struct dentry *, umode_t); 55 55 extern int cifs_rmdir(struct inode *, struct dentry *); 56 56 extern int cifs_rename(struct inode *, struct dentry *, struct inode *, 57 57 struct dentry *);

+2 -2

fs/cifs/inode.c

reviewed

··· 1264 1264 return rc; 1265 1265 } 1266 1266 1267 1267 - int cifs_mkdir(struct inode *inode, struct dentry *direntry, int mode) 1267 1267 + int cifs_mkdir(struct inode *inode, struct dentry *direntry, umode_t mode) 1268 1268 { 1269 1269 int rc = 0, tmprc; 1270 1270 int xid; ··· 1275 1275 struct inode *newinode = NULL; 1276 1276 struct cifs_fattr fattr; 1277 1277 1278 1278 - cFYI(1, "In cifs_mkdir, mode = 0x%x inode = 0x%p", mode, inode); 1278 1278 + cFYI(1, "In cifs_mkdir, mode = 0x%hx inode = 0x%p", mode, inode); 1279 1279 1280 1280 cifs_sb = CIFS_SB(inode->i_sb); 1281 1281 tlink = cifs_sb_tlink(cifs_sb);

+2 -2

fs/coda/dir.c

reviewed

··· 37 37 static int coda_unlink(struct inode *dir_inode, struct dentry *entry); 38 38 static int coda_symlink(struct inode *dir_inode, struct dentry *entry, 39 39 const char *symname); 40 40 - static int coda_mkdir(struct inode *dir_inode, struct dentry *entry, int mode); 40 40 + static int coda_mkdir(struct inode *dir_inode, struct dentry *entry, umode_t mode); 41 41 static int coda_rmdir(struct inode *dir_inode, struct dentry *entry); 42 42 static int coda_rename(struct inode *old_inode, struct dentry *old_dentry, 43 43 struct inode *new_inode, struct dentry *new_dentry); ··· 223 223 return error; 224 224 } 225 225 226 226 - static int coda_mkdir(struct inode *dir, struct dentry *de, int mode) 226 226 + static int coda_mkdir(struct inode *dir, struct dentry *de, umode_t mode) 227 227 { 228 228 struct inode *inode; 229 229 struct coda_vattr attrs;

+1 -1

fs/configfs/dir.c

reviewed

··· 1170 1170 } 1171 1171 EXPORT_SYMBOL(configfs_undepend_item); 1172 1172 1173 1173 - static int configfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 1173 1173 + static int configfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 1174 1174 { 1175 1175 int ret = 0; 1176 1176 int module_got = 0;

+1 -1

fs/ecryptfs/inode.c

reviewed

··· 559 559 return rc; 560 560 } 561 561 562 562 - static int ecryptfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 562 562 + static int ecryptfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 563 563 { 564 564 int rc; 565 565 struct dentry *lower_dentry;

+1 -1

fs/exofs/namei.c

reviewed

··· 153 153 return exofs_add_nondir(dentry, inode); 154 154 } 155 155 156 156 - static int exofs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 156 156 + static int exofs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 157 157 { 158 158 struct inode *inode; 159 159 int err = -EMLINK;

+1 -1

fs/ext2/namei.c

reviewed

··· 214 214 return err; 215 215 } 216 216 217 217 - static int ext2_mkdir(struct inode * dir, struct dentry * dentry, int mode) 217 217 + static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 218 218 { 219 219 struct inode * inode; 220 220 int err = -EMLINK;

+1 -1

fs/ext3/namei.c

reviewed

··· 1768 1768 return err; 1769 1769 } 1770 1770 1771 1771 - static int ext3_mkdir(struct inode * dir, struct dentry * dentry, int mode) 1771 1771 + static int ext3_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 1772 1772 { 1773 1773 handle_t *handle; 1774 1774 struct inode * inode;

+1 -1

fs/ext4/namei.c

reviewed

··· 1806 1806 return err; 1807 1807 } 1808 1808 1809 1809 - static int ext4_mkdir(struct inode *dir, struct dentry *dentry, int mode) 1809 1809 + static int ext4_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 1810 1810 { 1811 1811 handle_t *handle; 1812 1812 struct inode *inode;

+1 -1

fs/fat/namei_msdos.c

reviewed

··· 346 346 } 347 347 348 348 /***** Make a directory */ 349 349 - static int msdos_mkdir(struct inode *dir, struct dentry *dentry, int mode) 349 349 + static int msdos_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 350 350 { 351 351 struct super_block *sb = dir->i_sb; 352 352 struct fat_slot_info sinfo;

+1 -1

fs/fat/namei_vfat.c

reviewed

··· 870 870 return err; 871 871 } 872 872 873 873 - static int vfat_mkdir(struct inode *dir, struct dentry *dentry, int mode) 873 873 + static int vfat_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 874 874 { 875 875 struct super_block *sb = dir->i_sb; 876 876 struct inode *inode;

+1 -1

fs/fuse/dir.c

reviewed

··· 585 585 return fuse_mknod(dir, entry, mode, 0); 586 586 } 587 587 588 588 - static int fuse_mkdir(struct inode *dir, struct dentry *entry, int mode) 588 588 + static int fuse_mkdir(struct inode *dir, struct dentry *entry, umode_t mode) 589 589 { 590 590 struct fuse_mkdir_in inarg; 591 591 struct fuse_conn *fc = get_fuse_conn(dir);

+1 -1

fs/gfs2/inode.c

reviewed

··· 1129 1129 * Returns: errno 1130 1130 */ 1131 1131 1132 1132 - static int gfs2_mkdir(struct inode *dir, struct dentry *dentry, int mode) 1132 1132 + static int gfs2_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 1133 1133 { 1134 1134 return gfs2_create_inode(dir, dentry, S_IFDIR | mode, 0, NULL, 0, 0); 1135 1135 }

+1 -1

fs/hfs/dir.c

reviewed

··· 216 216 * in a directory, given the inode for the parent directory and the 217 217 * name (and its length) of the new directory. 218 218 */ 219 219 - static int hfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 219 219 + static int hfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 220 220 { 221 221 struct inode *inode; 222 222 int res;

+1 -1

fs/hfsplus/dir.c

reviewed

··· 459 459 return hfsplus_mknod(dir, dentry, mode, 0); 460 460 } 461 461 462 462 - static int hfsplus_mkdir(struct inode *dir, struct dentry *dentry, int mode) 462 462 + static int hfsplus_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 463 463 { 464 464 return hfsplus_mknod(dir, dentry, mode | S_IFDIR, 0); 465 465 }

+1 -1

fs/hostfs/hostfs_kern.c

reviewed

··· 676 676 return err; 677 677 } 678 678 679 679 - int hostfs_mkdir(struct inode *ino, struct dentry *dentry, int mode) 679 679 + int hostfs_mkdir(struct inode *ino, struct dentry *dentry, umode_t mode) 680 680 { 681 681 char *file; 682 682 int err;

+1 -1

fs/hpfs/namei.c

reviewed

··· 8 8 #include <linux/sched.h> 9 9 #include "hpfs_fn.h" 10 10 11 11 - static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 11 11 + static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 12 12 { 13 13 const unsigned char *name = dentry->d_name.name; 14 14 unsigned len = dentry->d_name.len;

+1 -1

fs/hugetlbfs/inode.c

reviewed

··· 523 523 return error; 524 524 } 525 525 526 526 - static int hugetlbfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 526 526 + static int hugetlbfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 527 527 { 528 528 int retval = hugetlbfs_mknod(dir, dentry, mode | S_IFDIR, 0); 529 529 if (!retval)

+2 -2

fs/jffs2/dir.c

reviewed

··· 29 29 static int jffs2_link (struct dentry *,struct inode *,struct dentry *); 30 30 static int jffs2_unlink (struct inode *,struct dentry *); 31 31 static int jffs2_symlink (struct inode *,struct dentry *,const char *); 32 32 - static int jffs2_mkdir (struct inode *,struct dentry *,int); 32 32 + static int jffs2_mkdir (struct inode *,struct dentry *,umode_t); 33 33 static int jffs2_rmdir (struct inode *,struct dentry *); 34 34 static int jffs2_mknod (struct inode *,struct dentry *,int,dev_t); 35 35 static int jffs2_rename (struct inode *, struct dentry *, ··· 450 450 } 451 451 452 452 453 453 - static int jffs2_mkdir (struct inode *dir_i, struct dentry *dentry, int mode) 453 453 + static int jffs2_mkdir (struct inode *dir_i, struct dentry *dentry, umode_t mode) 454 454 { 455 455 struct jffs2_inode_info *f, *dir_f; 456 456 struct jffs2_sb_info *c;

+1 -1

fs/jfs/namei.c

reviewed

··· 205 205 * note: 206 206 * EACCESS: user needs search+write permission on the parent directory 207 207 */ 208 208 - static int jfs_mkdir(struct inode *dip, struct dentry *dentry, int mode) 208 208 + static int jfs_mkdir(struct inode *dip, struct dentry *dentry, umode_t mode) 209 209 { 210 210 int rc = 0; 211 211 tid_t tid; /* transaction id */

+1 -1

fs/logfs/dir.c

reviewed

··· 482 482 return ret; 483 483 } 484 484 485 485 - static int logfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 485 485 + static int logfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 486 486 { 487 487 struct inode *inode; 488 488

+1 -1

fs/minix/namei.c

reviewed

··· 103 103 return add_nondir(dentry, inode); 104 104 } 105 105 106 106 - static int minix_mkdir(struct inode * dir, struct dentry *dentry, int mode) 106 106 + static int minix_mkdir(struct inode * dir, struct dentry *dentry, umode_t mode) 107 107 { 108 108 struct inode * inode; 109 109 int err = -EMLINK;

+1 -1

fs/namei.c

reviewed

··· 2541 2541 return sys_mknodat(AT_FDCWD, filename, mode, dev); 2542 2542 } 2543 2543 2544 2544 - int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 2544 2544 + int vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 2545 2545 { 2546 2546 int error = may_create(dir, dentry); 2547 2547

+2 -2

fs/ncpfs/dir.c

reviewed

··· 33 33 static int ncp_create(struct inode *, struct dentry *, int, struct nameidata *); 34 34 static struct dentry *ncp_lookup(struct inode *, struct dentry *, struct nameidata *); 35 35 static int ncp_unlink(struct inode *, struct dentry *); 36 36 - static int ncp_mkdir(struct inode *, struct dentry *, int); 36 36 + static int ncp_mkdir(struct inode *, struct dentry *, umode_t); 37 37 static int ncp_rmdir(struct inode *, struct dentry *); 38 38 static int ncp_rename(struct inode *, struct dentry *, 39 39 struct inode *, struct dentry *); ··· 985 985 return ncp_create_new(dir, dentry, mode, 0, 0); 986 986 } 987 987 988 988 - static int ncp_mkdir(struct inode *dir, struct dentry *dentry, int mode) 988 988 + static int ncp_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 989 989 { 990 990 struct ncp_entry_info finfo; 991 991 struct ncp_server *server = NCP_SERVER(dir);

+2 -2

fs/nfs/dir.c

reviewed

··· 48 48 static int nfs_readdir(struct file *, void *, filldir_t); 49 49 static struct dentry *nfs_lookup(struct inode *, struct dentry *, struct nameidata *); 50 50 static int nfs_create(struct inode *, struct dentry *, int, struct nameidata *); 51 51 - static int nfs_mkdir(struct inode *, struct dentry *, int); 51 51 + static int nfs_mkdir(struct inode *, struct dentry *, umode_t); 52 52 static int nfs_rmdir(struct inode *, struct dentry *); 53 53 static int nfs_unlink(struct inode *, struct dentry *); 54 54 static int nfs_symlink(struct inode *, struct dentry *, const char *); ··· 1719 1719 /* 1720 1720 * See comments for nfs_proc_create regarding failed operations. 1721 1721 */ 1722 1722 - static int nfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 1722 1722 + static int nfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 1723 1723 { 1724 1724 struct iattr attr; 1725 1725 int error;

+1 -1

fs/nilfs2/namei.c

reviewed

··· 213 213 return err; 214 214 } 215 215 216 216 - static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 216 216 + static int nilfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 217 217 { 218 218 struct inode *inode; 219 219 struct nilfs_transaction_info ti;

+1 -1

fs/ocfs2/dlmfs/dlmfs.c

reviewed

··· 488 488 /* SMP-safe */ 489 489 static int dlmfs_mkdir(struct inode * dir, 490 490 struct dentry * dentry, 491 491 - int mode) 491 491 + umode_t mode) 492 492 { 493 493 int status; 494 494 struct inode *inode = NULL;

+1 -1

fs/ocfs2/namei.c

reviewed

··· 602 602 603 603 static int ocfs2_mkdir(struct inode *dir, 604 604 struct dentry *dentry, 605 605 - int mode) 605 605 + umode_t mode) 606 606 { 607 607 int ret; 608 608

+1 -1

fs/omfs/dir.c

reviewed

··· 279 279 return err; 280 280 } 281 281 282 282 - static int omfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 282 282 + static int omfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 283 283 { 284 284 return omfs_add_node(dir, dentry, mode | S_IFDIR); 285 285 }

+1 -1

fs/ramfs/inode.c

reviewed

··· 106 106 return error; 107 107 } 108 108 109 109 - static int ramfs_mkdir(struct inode * dir, struct dentry * dentry, int mode) 109 109 + static int ramfs_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 110 110 { 111 111 int retval = ramfs_mknod(dir, dentry, mode | S_IFDIR, 0); 112 112 if (!retval)

+1 -1

fs/reiserfs/namei.c

reviewed

··· 721 721 return retval; 722 722 } 723 723 724 724 - static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 724 724 + static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 725 725 { 726 726 int retval; 727 727 struct inode *inode;

+1 -1

fs/reiserfs/xattr.c

reviewed

··· 66 66 } 67 67 #endif 68 68 69 69 - static int xattr_mkdir(struct inode *dir, struct dentry *dentry, int mode) 69 69 + static int xattr_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 70 70 { 71 71 BUG_ON(!mutex_is_locked(&dir->i_mutex)); 72 72 return dir->i_op->mkdir(dir, dentry, mode);

+1 -1

fs/sysv/namei.c

reviewed

··· 131 131 return add_nondir(dentry, inode); 132 132 } 133 133 134 134 - static int sysv_mkdir(struct inode * dir, struct dentry *dentry, int mode) 134 134 + static int sysv_mkdir(struct inode * dir, struct dentry *dentry, umode_t mode) 135 135 { 136 136 struct inode * inode; 137 137 int err = -EMLINK;

+2 -2

fs/ubifs/dir.c

reviewed

··· 712 712 return err; 713 713 } 714 714 715 715 - static int ubifs_mkdir(struct inode *dir, struct dentry *dentry, int mode) 715 715 + static int ubifs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 716 716 { 717 717 struct inode *inode; 718 718 struct ubifs_inode *dir_ui = ubifs_inode(dir); ··· 725 725 * directory inode. 726 726 */ 727 727 728 728 - dbg_gen("dent '%.*s', mode %#x in dir ino %lu", 728 728 + dbg_gen("dent '%.*s', mode %#hx in dir ino %lu", 729 729 dentry->d_name.len, dentry->d_name.name, mode, dir->i_ino); 730 730 731 731 err = ubifs_budget_space(c, &req);

+1 -1

fs/udf/namei.c

reviewed

··· 640 640 return err; 641 641 } 642 642 643 643 - static int udf_mkdir(struct inode *dir, struct dentry *dentry, int mode) 643 643 + static int udf_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 644 644 { 645 645 struct inode *inode; 646 646 struct udf_fileident_bh fibh;

+1 -1

fs/ufs/namei.c

reviewed

··· 180 180 return error; 181 181 } 182 182 183 183 - static int ufs_mkdir(struct inode * dir, struct dentry * dentry, int mode) 183 183 + static int ufs_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 184 184 { 185 185 struct inode * inode; 186 186 int err = -EMLINK;

+1 -1

fs/xfs/xfs_iops.c

reviewed

··· 241 241 xfs_vn_mkdir( 242 242 struct inode *dir, 243 243 struct dentry *dentry, 244 244 - int mode) 244 244 + umode_t mode) 245 245 { 246 246 return xfs_vn_mknod(dir, dentry, mode|S_IFDIR, 0); 247 247 }

+2 -2

include/linux/fs.h

reviewed

··· 1517 1517 * VFS helper functions.. 1518 1518 */ 1519 1519 extern int vfs_create(struct inode *, struct dentry *, int, struct nameidata *); 1520 1520 - extern int vfs_mkdir(struct inode *, struct dentry *, int); 1520 1520 + extern int vfs_mkdir(struct inode *, struct dentry *, umode_t); 1521 1521 extern int vfs_mknod(struct inode *, struct dentry *, int, dev_t); 1522 1522 extern int vfs_symlink(struct inode *, struct dentry *, const char *); 1523 1523 extern int vfs_link(struct dentry *, struct inode *, struct dentry *); ··· 1623 1623 int (*link) (struct dentry *,struct inode *,struct dentry *); 1624 1624 int (*unlink) (struct inode *,struct dentry *); 1625 1625 int (*symlink) (struct inode *,struct dentry *,const char *); 1626 1626 - int (*mkdir) (struct inode *,struct dentry *,int); 1626 1626 + int (*mkdir) (struct inode *,struct dentry *,umode_t); 1627 1627 int (*rmdir) (struct inode *,struct dentry *); 1628 1628 int (*mknod) (struct inode *,struct dentry *,int,dev_t); 1629 1629 int (*rename) (struct inode *, struct dentry *,

+2 -2

include/linux/security.h

reviewed

··· 1453 1453 int (*inode_unlink) (struct inode *dir, struct dentry *dentry); 1454 1454 int (*inode_symlink) (struct inode *dir, 1455 1455 struct dentry *dentry, const char *old_name); 1456 1456 - int (*inode_mkdir) (struct inode *dir, struct dentry *dentry, int mode); 1456 1456 + int (*inode_mkdir) (struct inode *dir, struct dentry *dentry, umode_t mode); 1457 1457 int (*inode_rmdir) (struct inode *dir, struct dentry *dentry); 1458 1458 int (*inode_mknod) (struct inode *dir, struct dentry *dentry, 1459 1459 int mode, dev_t dev); ··· 1722 1722 int security_inode_unlink(struct inode *dir, struct dentry *dentry); 1723 1723 int security_inode_symlink(struct inode *dir, struct dentry *dentry, 1724 1724 const char *old_name); 1725 1725 - int security_inode_mkdir(struct inode *dir, struct dentry *dentry, int mode); 1725 1725 + int security_inode_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); 1726 1726 int security_inode_rmdir(struct inode *dir, struct dentry *dentry); 1727 1727 int security_inode_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev); 1728 1728 int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry,

+2 -2

kernel/cgroup.c

reviewed

··· 760 760 * -> cgroup_mkdir. 761 761 */ 762 762 763 763 - static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, int mode); 763 763 + static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode); 764 764 static struct dentry *cgroup_lookup(struct inode *, struct dentry *, struct nameidata *); 765 765 static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry); 766 766 static int cgroup_populate_dir(struct cgroup *cgrp); ··· 3846 3846 return err; 3847 3847 } 3848 3848 3849 3849 - static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, int mode) 3849 3849 + static int cgroup_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 3850 3850 { 3851 3851 struct cgroup *c_parent = dentry->d_parent->d_fsdata; 3852 3852

+1 -1

mm/shmem.c

reviewed

··· 1489 1489 return error; 1490 1490 } 1491 1491 1492 1492 - static int shmem_mkdir(struct inode *dir, struct dentry *dentry, int mode) 1492 1492 + static int shmem_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 1493 1493 { 1494 1494 int error; 1495 1495

+1 -1

security/capability.c

reviewed

··· 148 148 } 149 149 150 150 static int cap_inode_mkdir(struct inode *inode, struct dentry *dentry, 151 151 - int mask) 151 151 + umode_t mask) 152 152 { 153 153 return 0; 154 154 }

+1 -1

security/security.c

reviewed

··· 506 506 return security_ops->inode_symlink(dir, dentry, old_name); 507 507 } 508 508 509 509 - int security_inode_mkdir(struct inode *dir, struct dentry *dentry, int mode) 509 509 + int security_inode_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) 510 510 { 511 511 if (unlikely(IS_PRIVATE(dir))) 512 512 return 0;

+1 -1

security/selinux/hooks.c

reviewed

··· 2618 2618 return may_create(dir, dentry, SECCLASS_LNK_FILE); 2619 2619 } 2620 2620 2621 2621 - static int selinux_inode_mkdir(struct inode *dir, struct dentry *dentry, int mask) 2621 2621 + static int selinux_inode_mkdir(struct inode *dir, struct dentry *dentry, umode_t mask) 2622 2622 { 2623 2623 return may_create(dir, dentry, SECCLASS_DIR); 2624 2624 }