Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: hpsa: remove printing internal cdb on tag collision

Remove racy printing of internal commands. Completion thread can be
cleaning up the command in parallel.

Reviewed-by: Bader Ali - Saleh <bader.alisaleh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Don Brace and committed by
Martin K. Petersen
18a56d69 eeebce18

-2
-2
drivers/scsi/hpsa.c
··· 6091 6091 if (idx != h->last_collision_tag) { /* Print once per tag */ 6092 6092 dev_warn(&h->pdev->dev, 6093 6093 "%s: tag collision (tag=%d)\n", __func__, idx); 6094 - if (c->scsi_cmd != NULL) 6095 - scsi_print_command(c->scsi_cmd); 6096 6094 if (scmd) 6097 6095 scsi_print_command(scmd); 6098 6096 h->last_collision_tag = idx;