Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: Use dp_to_i915 on intel_psr.c

Now that we have a generic caller let's simplify it and
clean up the intel_psr.c code a bit.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180827223021.7145-2-rodrigo.vivi@intel.com

+14 -36
+14 -36
drivers/gpu/drm/i915/intel_psr.c
··· 270 270 const struct intel_crtc_state *crtc_state) 271 271 { 272 272 struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 273 - struct drm_i915_private *dev_priv = to_i915(intel_dig_port->base.base.dev); 273 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 274 274 struct edp_vsc_psr psr_vsc; 275 275 276 276 if (dev_priv->psr.psr2_enabled) { ··· 300 300 301 301 static void hsw_psr_setup_aux(struct intel_dp *intel_dp) 302 302 { 303 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 304 - struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev); 303 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 305 304 u32 aux_clock_divider, aux_ctl; 306 305 int i; 307 306 static const uint8_t aux_msg[] = { ··· 333 334 334 335 static void intel_psr_enable_sink(struct intel_dp *intel_dp) 335 336 { 336 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 337 - struct drm_device *dev = dig_port->base.base.dev; 338 - struct drm_i915_private *dev_priv = to_i915(dev); 337 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 339 338 u8 dpcd_val = DP_PSR_ENABLE; 340 339 341 340 /* Enable ALPM at sink for psr2 */ ··· 354 357 355 358 static void hsw_activate_psr1(struct intel_dp *intel_dp) 356 359 { 357 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 358 - struct drm_device *dev = dig_port->base.base.dev; 359 - struct drm_i915_private *dev_priv = to_i915(dev); 360 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 360 361 u32 max_sleep_time = 0x1f; 361 362 u32 val = EDP_PSR_ENABLE; 362 363 ··· 409 414 410 415 static void hsw_activate_psr2(struct intel_dp *intel_dp) 411 416 { 412 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 413 - struct drm_device *dev = dig_port->base.base.dev; 414 - struct drm_i915_private *dev_priv = to_i915(dev); 417 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 415 418 u32 val; 416 419 417 420 /* Let's use 6 as the minimum to cover all known cases including the ··· 445 452 static bool intel_psr2_config_valid(struct intel_dp *intel_dp, 446 453 struct intel_crtc_state *crtc_state) 447 454 { 448 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 449 - struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev); 455 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 450 456 int crtc_hdisplay = crtc_state->base.adjusted_mode.crtc_hdisplay; 451 457 int crtc_vdisplay = crtc_state->base.adjusted_mode.crtc_vdisplay; 452 458 int psr_max_h = 0, psr_max_v = 0; ··· 480 488 struct intel_crtc_state *crtc_state) 481 489 { 482 490 struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 483 - struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev); 491 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 484 492 const struct drm_display_mode *adjusted_mode = 485 493 &crtc_state->base.adjusted_mode; 486 494 int psr_setup_time; ··· 536 544 537 545 static void intel_psr_activate(struct intel_dp *intel_dp) 538 546 { 539 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 540 - struct drm_device *dev = intel_dig_port->base.base.dev; 541 - struct drm_i915_private *dev_priv = to_i915(dev); 547 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 542 548 543 549 if (INTEL_GEN(dev_priv) >= 9) 544 550 WARN_ON(I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE); ··· 556 566 static void intel_psr_enable_source(struct intel_dp *intel_dp, 557 567 const struct intel_crtc_state *crtc_state) 558 568 { 559 - struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 560 - struct drm_device *dev = dig_port->base.base.dev; 561 - struct drm_i915_private *dev_priv = to_i915(dev); 569 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 562 570 enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; 563 571 564 572 /* Only HSW and BDW have PSR AUX registers that need to be setup. SKL+ ··· 627 639 void intel_psr_enable(struct intel_dp *intel_dp, 628 640 const struct intel_crtc_state *crtc_state) 629 641 { 630 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 631 - struct drm_device *dev = intel_dig_port->base.base.dev; 632 - struct drm_i915_private *dev_priv = to_i915(dev); 642 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 633 643 634 644 if (!crtc_state->has_psr) 635 645 return; ··· 659 673 static void 660 674 intel_psr_disable_source(struct intel_dp *intel_dp) 661 675 { 662 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 663 - struct drm_device *dev = intel_dig_port->base.base.dev; 664 - struct drm_i915_private *dev_priv = to_i915(dev); 676 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 665 677 666 678 if (dev_priv->psr.active) { 667 679 i915_reg_t psr_status; ··· 698 714 699 715 static void intel_psr_disable_locked(struct intel_dp *intel_dp) 700 716 { 701 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 702 - struct drm_device *dev = intel_dig_port->base.base.dev; 703 - struct drm_i915_private *dev_priv = to_i915(dev); 717 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 704 718 705 719 lockdep_assert_held(&dev_priv->psr.lock); 706 720 ··· 725 743 void intel_psr_disable(struct intel_dp *intel_dp, 726 744 const struct intel_crtc_state *old_crtc_state) 727 745 { 728 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 729 - struct drm_device *dev = intel_dig_port->base.base.dev; 730 - struct drm_i915_private *dev_priv = to_i915(dev); 746 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 731 747 732 748 if (!old_crtc_state->has_psr) 733 749 return; ··· 1082 1102 1083 1103 void intel_psr_short_pulse(struct intel_dp *intel_dp) 1084 1104 { 1085 - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); 1086 - struct drm_device *dev = intel_dig_port->base.base.dev; 1087 - struct drm_i915_private *dev_priv = to_i915(dev); 1105 + struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 1088 1106 struct i915_psr *psr = &dev_priv->psr; 1089 1107 u8 val; 1090 1108 const u8 errors = DP_PSR_RFB_STORAGE_ERROR |