Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'reset-fixes-for-4.14' of git://git.pengutronix.de/git/pza/linux into fixes

Reset controller fixes for v4.14

- Remove misleading HSDK v1 suffix, as there is no v2 planned
- Add missing DT binding documentation for HSDK reset driver
- Fix HSDK reset driver dependencies

* tag 'reset-fixes-for-4.14' of git://git.pengutronix.de/git/pza/linux:
reset: Restrict RESET_HSDK to ARC_SOC_HSDK or COMPILE_TEST
ARC: reset: remove the misleading v1 suffix all over
ARC: reset: add missing DT binding documentation for HSDKv1 reset driver
ARC: reset: Only build on archs that have IOMEM

Signed-off-by: Olof Johansson <olof@lixom.net>

+76 -47
+28
Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt
··· 1 + Binding for the Synopsys HSDK reset controller 2 + 3 + This binding uses the common reset binding[1]. 4 + 5 + [1] Documentation/devicetree/bindings/reset/reset.txt 6 + 7 + Required properties: 8 + - compatible: should be "snps,hsdk-reset". 9 + - reg: should always contain 2 pairs address - length: first for reset 10 + configuration register and second for corresponding SW reset and status bits 11 + register. 12 + - #reset-cells: from common reset binding; Should always be set to 1. 13 + 14 + Example: 15 + reset: reset@880 { 16 + compatible = "snps,hsdk-reset"; 17 + #reset-cells = <1>; 18 + reg = <0x8A0 0x4>, <0xFF0 0x4>; 19 + }; 20 + 21 + Specifying reset lines connected to IP modules: 22 + ethernet@.... { 23 + .... 24 + resets = <&reset HSDK_V1_ETH_RESET>; 25 + .... 26 + }; 27 + 28 + The index could be found in <dt-bindings/reset/snps,hsdk-reset.h>
+3 -3
MAINTAINERS
··· 12931 12931 SYNOPSYS HSDK RESET CONTROLLER DRIVER 12932 12932 M: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> 12933 12933 S: Supported 12934 - F: drivers/reset/reset-hsdk-v1.c 12935 - F: include/dt-bindings/reset/snps,hsdk-v1-reset.h 12936 - F: Documentation/devicetree/bindings/reset/snps,hsdk-v1-reset.txt 12934 + F: drivers/reset/reset-hsdk.c 12935 + F: include/dt-bindings/reset/snps,hsdk-reset.h 12936 + F: Documentation/devicetree/bindings/reset/snps,hsdk-reset.txt 12937 12937 12938 12938 SYSTEM CONFIGURATION (SYSCON) 12939 12939 M: Lee Jones <lee.jones@linaro.org>
+5 -4
drivers/reset/Kconfig
··· 34 34 help 35 35 This enables the reset controller driver for Marvell Berlin SoCs. 36 36 37 - config RESET_HSDK_V1 38 - bool "HSDK v1 Reset Driver" 39 - default n 37 + config RESET_HSDK 38 + bool "Synopsys HSDK Reset Driver" 39 + depends on HAS_IOMEM 40 + depends on ARC_SOC_HSDK || COMPILE_TEST 40 41 help 41 - This enables the reset controller driver for HSDK v1. 42 + This enables the reset controller driver for HSDK board. 42 43 43 44 config RESET_IMX7 44 45 bool "i.MX7 Reset Driver" if COMPILE_TEST
+1 -1
drivers/reset/Makefile
··· 5 5 obj-$(CONFIG_RESET_A10SR) += reset-a10sr.o 6 6 obj-$(CONFIG_RESET_ATH79) += reset-ath79.o 7 7 obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o 8 - obj-$(CONFIG_RESET_HSDK_V1) += reset-hsdk-v1.o 8 + obj-$(CONFIG_RESET_HSDK) += reset-hsdk.o 9 9 obj-$(CONFIG_RESET_IMX7) += reset-imx7.o 10 10 obj-$(CONFIG_RESET_LANTIQ) += reset-lantiq.o 11 11 obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
+22 -22
drivers/reset/reset-hsdk-v1.c drivers/reset/reset-hsdk.c
··· 1 1 /* 2 2 * Copyright (C) 2017 Synopsys. 3 3 * 4 - * Synopsys HSDKv1 SDP reset driver. 4 + * Synopsys HSDK Development platform reset driver. 5 5 * 6 6 * This file is licensed under the terms of the GNU General Public 7 7 * License version 2. This program is licensed "as is" without any ··· 18 18 #include <linux/slab.h> 19 19 #include <linux/types.h> 20 20 21 - #define to_hsdkv1_rst(p) container_of((p), struct hsdkv1_rst, rcdev) 21 + #define to_hsdk_rst(p) container_of((p), struct hsdk_rst, rcdev) 22 22 23 - struct hsdkv1_rst { 23 + struct hsdk_rst { 24 24 void __iomem *regs_ctl; 25 25 void __iomem *regs_rst; 26 26 spinlock_t lock; ··· 49 49 #define CGU_IP_SW_RESET_RESET BIT(0) 50 50 #define SW_RESET_TIMEOUT 10000 51 51 52 - static void hsdkv1_reset_config(struct hsdkv1_rst *rst, unsigned long id) 52 + static void hsdk_reset_config(struct hsdk_rst *rst, unsigned long id) 53 53 { 54 54 writel(rst_map[id], rst->regs_ctl + CGU_SYS_RST_CTRL); 55 55 } 56 56 57 - static int hsdkv1_reset_do(struct hsdkv1_rst *rst) 57 + static int hsdk_reset_do(struct hsdk_rst *rst) 58 58 { 59 59 u32 reg; 60 60 ··· 69 69 !(reg & CGU_IP_SW_RESET_RESET), 5, SW_RESET_TIMEOUT); 70 70 } 71 71 72 - static int hsdkv1_reset_reset(struct reset_controller_dev *rcdev, 72 + static int hsdk_reset_reset(struct reset_controller_dev *rcdev, 73 73 unsigned long id) 74 74 { 75 - struct hsdkv1_rst *rst = to_hsdkv1_rst(rcdev); 75 + struct hsdk_rst *rst = to_hsdk_rst(rcdev); 76 76 unsigned long flags; 77 77 int ret; 78 78 79 79 spin_lock_irqsave(&rst->lock, flags); 80 - hsdkv1_reset_config(rst, id); 81 - ret = hsdkv1_reset_do(rst); 80 + hsdk_reset_config(rst, id); 81 + ret = hsdk_reset_do(rst); 82 82 spin_unlock_irqrestore(&rst->lock, flags); 83 83 84 84 return ret; 85 85 } 86 86 87 - static const struct reset_control_ops hsdkv1_reset_ops = { 88 - .reset = hsdkv1_reset_reset, 87 + static const struct reset_control_ops hsdk_reset_ops = { 88 + .reset = hsdk_reset_reset, 89 89 }; 90 90 91 - static int hsdkv1_reset_probe(struct platform_device *pdev) 91 + static int hsdk_reset_probe(struct platform_device *pdev) 92 92 { 93 - struct hsdkv1_rst *rst; 93 + struct hsdk_rst *rst; 94 94 struct resource *mem; 95 95 96 96 rst = devm_kzalloc(&pdev->dev, sizeof(*rst), GFP_KERNEL); ··· 110 110 spin_lock_init(&rst->lock); 111 111 112 112 rst->rcdev.owner = THIS_MODULE; 113 - rst->rcdev.ops = &hsdkv1_reset_ops; 113 + rst->rcdev.ops = &hsdk_reset_ops; 114 114 rst->rcdev.of_node = pdev->dev.of_node; 115 115 rst->rcdev.nr_resets = HSDK_MAX_RESETS; 116 116 rst->rcdev.of_reset_n_cells = 1; ··· 118 118 return reset_controller_register(&rst->rcdev); 119 119 } 120 120 121 - static const struct of_device_id hsdkv1_reset_dt_match[] = { 122 - { .compatible = "snps,hsdk-v1.0-reset" }, 121 + static const struct of_device_id hsdk_reset_dt_match[] = { 122 + { .compatible = "snps,hsdk-reset" }, 123 123 { }, 124 124 }; 125 125 126 - static struct platform_driver hsdkv1_reset_driver = { 127 - .probe = hsdkv1_reset_probe, 126 + static struct platform_driver hsdk_reset_driver = { 127 + .probe = hsdk_reset_probe, 128 128 .driver = { 129 - .name = "hsdk-v1.0-reset", 130 - .of_match_table = hsdkv1_reset_dt_match, 129 + .name = "hsdk-reset", 130 + .of_match_table = hsdk_reset_dt_match, 131 131 }, 132 132 }; 133 - builtin_platform_driver(hsdkv1_reset_driver); 133 + builtin_platform_driver(hsdk_reset_driver); 134 134 135 135 MODULE_AUTHOR("Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>"); 136 - MODULE_DESCRIPTION("Synopsys HSDKv1 SDP reset driver"); 136 + MODULE_DESCRIPTION("Synopsys HSDK SDP reset driver"); 137 137 MODULE_LICENSE("GPL v2");
+17
include/dt-bindings/reset/snps,hsdk-reset.h
··· 1 + /** 2 + * This header provides index for the HSDK reset controller. 3 + */ 4 + #ifndef _DT_BINDINGS_RESET_CONTROLLER_SNPS_HSDK 5 + #define _DT_BINDINGS_RESET_CONTROLLER_SNPS_HSDK 6 + 7 + #define HSDK_APB_RESET 0 8 + #define HSDK_AXI_RESET 1 9 + #define HSDK_ETH_RESET 2 10 + #define HSDK_USB_RESET 3 11 + #define HSDK_SDIO_RESET 4 12 + #define HSDK_HDMI_RESET 5 13 + #define HSDK_GFX_RESET 6 14 + #define HSDK_DMAC_RESET 7 15 + #define HSDK_EBI_RESET 8 16 + 17 + #endif /*_DT_BINDINGS_RESET_CONTROLLER_SNPS_HSDK*/
-17
include/dt-bindings/reset/snps,hsdk-v1-reset.h
··· 1 - /** 2 - * This header provides index for the HSDK v1 reset controller. 3 - */ 4 - #ifndef _DT_BINDINGS_RESET_CONTROLLER_HSDK_V1 5 - #define _DT_BINDINGS_RESET_CONTROLLER_HSDK_V1 6 - 7 - #define HSDK_V1_APB_RESET 0 8 - #define HSDK_V1_AXI_RESET 1 9 - #define HSDK_V1_ETH_RESET 2 10 - #define HSDK_V1_USB_RESET 3 11 - #define HSDK_V1_SDIO_RESET 4 12 - #define HSDK_V1_HDMI_RESET 5 13 - #define HSDK_V1_GFX_RESET 6 14 - #define HSDK_V1_DMAC_RESET 7 15 - #define HSDK_V1_EBI_RESET 8 16 - 17 - #endif /*_DT_BINDINGS_RESET_CONTROLLER_HSDK_V1*/