Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: i2c: ov9650: Use the v4l2 helper for obtaining the clock

devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Mehdi Djait and committed by
Hans Verkuil
1808dd60 f9f6ebba

+3 -2
+3 -2
drivers/media/i2c/ov9650.c
··· 1494 1494 } 1495 1495 1496 1496 if (dev_fwnode(&client->dev)) { 1497 - ov965x->clk = devm_clk_get(&client->dev, NULL); 1497 + ov965x->clk = devm_v4l2_sensor_clk_get(&client->dev, NULL); 1498 1498 if (IS_ERR(ov965x->clk)) 1499 - return PTR_ERR(ov965x->clk); 1499 + return dev_err_probe(&client->dev, PTR_ERR(ov965x->clk), 1500 + "failed to get the clock\n"); 1500 1501 ov965x->mclk_frequency = clk_get_rate(ov965x->clk); 1501 1502 1502 1503 ret = ov965x_configure_gpios(ov965x);