Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/exynos/dsi: use of_graph_get_endpoint_by_regs helper

This allows to remove the local of_graph_get_port_by_reg(),
of_graph_get_endpoint_by_reg(), and of_get_child_by_name_reg()
functions.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Inki Dae <inki.dae@samsung.com>

authored by

Philipp Zabel and committed by
Inki Dae
17ef49bd fb38b1f6

+3 -54
+3 -54
drivers/gpu/drm/exynos/exynos_drm_dsi.c
··· 1632 1632 1633 1633 MODULE_DEVICE_TABLE(of, exynos_dsi_of_match); 1634 1634 1635 - /* of_* functions will be removed after merge of of_graph patches */ 1636 - static struct device_node * 1637 - of_get_child_by_name_reg(struct device_node *parent, const char *name, u32 reg) 1638 - { 1639 - struct device_node *np; 1640 - 1641 - for_each_child_of_node(parent, np) { 1642 - u32 r; 1643 - 1644 - if (!np->name || of_node_cmp(np->name, name)) 1645 - continue; 1646 - 1647 - if (of_property_read_u32(np, "reg", &r) < 0) 1648 - r = 0; 1649 - 1650 - if (reg == r) 1651 - break; 1652 - } 1653 - 1654 - return np; 1655 - } 1656 - 1657 - static struct device_node *of_graph_get_port_by_reg(struct device_node *parent, 1658 - u32 reg) 1659 - { 1660 - struct device_node *ports, *port; 1661 - 1662 - ports = of_get_child_by_name(parent, "ports"); 1663 - if (ports) 1664 - parent = ports; 1665 - 1666 - port = of_get_child_by_name_reg(parent, "port", reg); 1667 - 1668 - of_node_put(ports); 1669 - 1670 - return port; 1671 - } 1672 - 1673 - static struct device_node * 1674 - of_graph_get_endpoint_by_reg(struct device_node *port, u32 reg) 1675 - { 1676 - return of_get_child_by_name_reg(port, "endpoint", reg); 1677 - } 1678 - 1679 1635 static int exynos_dsi_of_read_u32(const struct device_node *np, 1680 1636 const char *propname, u32 *out_value) 1681 1637 { ··· 1653 1697 { 1654 1698 struct device *dev = dsi->dev; 1655 1699 struct device_node *node = dev->of_node; 1656 - struct device_node *port, *ep; 1700 + struct device_node *ep; 1657 1701 int ret; 1658 1702 1659 1703 ret = exynos_dsi_of_read_u32(node, "samsung,pll-clock-frequency", ··· 1661 1705 if (ret < 0) 1662 1706 return ret; 1663 1707 1664 - port = of_graph_get_port_by_reg(node, DSI_PORT_OUT); 1665 - if (!port) { 1666 - dev_err(dev, "no output port specified\n"); 1667 - return -EINVAL; 1668 - } 1669 - 1670 - ep = of_graph_get_endpoint_by_reg(port, 0); 1671 - of_node_put(port); 1708 + ep = of_graph_get_endpoint_by_regs(node, DSI_PORT_OUT, 0); 1672 1709 if (!ep) { 1673 - dev_err(dev, "no endpoint specified in output port\n"); 1710 + dev_err(dev, "no output port with endpoint specified\n"); 1674 1711 return -EINVAL; 1675 1712 } 1676 1713