Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MSI: Rename pci_msi_supported() to pci_msi_check_device()

As pointed out by Eric, the name pci_msi_supported() suggests it should
return a boolean value, however it doesn't. So update the name to be
a bit less confusing and update the doco too.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Michael Ellerman and committed by
Greg Kroah-Hartman
17bbc12a 128bc5fc

+6 -6
+6 -6
drivers/pci/msi.c
··· 457 457 } 458 458 459 459 /** 460 - * pci_msi_supported - check whether MSI may be enabled on device 460 + * pci_msi_check_device - check whether MSI may be enabled on a device 461 461 * @dev: pointer to the pci_dev data structure of MSI device function 462 462 * @type: are we checking for MSI or MSI-X ? 463 463 * 464 464 * Look at global flags, the device itself, and its parent busses 465 - * to return 0 if MSI are supported for the device. 465 + * to determine if MSI/-X are supported for the device. If MSI/-X is 466 + * supported return 0, else return an error code. 466 467 **/ 467 - static 468 - int pci_msi_supported(struct pci_dev * dev, int type) 468 + static int pci_msi_check_device(struct pci_dev * dev, int type) 469 469 { 470 470 struct pci_bus *bus; 471 471 ··· 503 503 { 504 504 int status; 505 505 506 - if (pci_msi_supported(dev, PCI_CAP_ID_MSI)) 506 + if (pci_msi_check_device(dev, PCI_CAP_ID_MSI)) 507 507 return -EINVAL; 508 508 509 509 WARN_ON(!!dev->msi_enabled); ··· 601 601 int i, j; 602 602 u16 control; 603 603 604 - if (!entries || pci_msi_supported(dev, PCI_CAP_ID_MSIX)) 604 + if (!entries || pci_msi_check_device(dev, PCI_CAP_ID_MSIX)) 605 605 return -EINVAL; 606 606 607 607 pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);