media: Use fallthrough pseudo-keyword · tjh.dev/kernel@1771e9f

tjh.dev / kernel

fork atom

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

fork atom

media: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Gustavo A. R. Silva and committed by

Mauro Carvalho Chehab 5 years ago 1771e9fb d7a81a5b

+94 -94

55 changed files

expand all collapse all

drivers

media

cec

core

cec-adap.c

cec-pin.c

usb

pulse8

pulse8-cec.c

common

videobuf2

videobuf2-v4l2.c

dvb-frontends

af9013.c

lg2160.c

m88ds3103.c

i2c

adv7180.c

adv7511-v4l2.c

msp3400-kthreads.c

ov5640.c

ov6650.c

ov9640.c

s5c73m3

s5c73m3-ctrls.c

smiapp

smiapp-core.c

tda1997x.c

tvp5150.c

pci

bt8xx

bttv-driver.c

cx88

cx88-cards.c

cx88-video.c

saa7134

saa7134-cards.c

solo6x10

solo6x10-core.c

solo6x10-i2c.c

platform

coda

coda-bit.c

coda-common.c

exynos4-is

fimc-capture.c

fimc-reg.c

media-dev.c

marvell-ccic

mcam-core.c

omap3isp

ispvideo.c

qcom

venus

vdec.c

renesas-ceu.c

radio

si4713

si4713.c

iguanair.c

test-drivers

vicodec

vicodec-core.c

vivid

vivid-vbi-gen.c

tuners

fc0011.c

tda18271-fe.c

usb

dvb-usb-v2

af9015.c

gl861.c

lmedm04.c

mxl111sf-gpio.c

em28xx

em28xx-audio.c

go7007

go7007-driver.c

gspca

mr97310a.c

nw80x.c

ov519.c

sn9c20x.c

sunplus.c

xirlink_cit.c

zc3xx.c

pwc

pwc-v4l.c

siano

smsusb.c

tm6000

tm6000-alsa.c

uvc

uvc_video.c

+1 -1

drivers/media/cec/core/cec-adap.c

reviewed

··· 1928 1928 */ 1929 1929 if (!adap->passthrough && from_unregistered) 1930 1930 return 0; 1931 1931 - /* Fall through */ 1931 1931 + fallthrough; 1932 1932 case CEC_MSG_GIVE_DEVICE_VENDOR_ID: 1933 1933 case CEC_MSG_GIVE_FEATURES: 1934 1934 case CEC_MSG_GIVE_PHYSICAL_ADDR:

+3 -3

drivers/media/cec/core/cec-pin.c

reviewed

··· 417 417 wake_up_interruptible(&pin->kthread_waitq); 418 418 break; 419 419 } 420 420 - /* fall through */ 420 420 + fallthrough; 421 421 case CEC_ST_TX_DATA_BIT_0_HIGH: 422 422 case CEC_ST_TX_DATA_BIT_0_HIGH_SHORT: 423 423 case CEC_ST_TX_DATA_BIT_0_HIGH_LONG: ··· 445 445 wake_up_interruptible(&pin->kthread_waitq); 446 446 break; 447 447 } 448 448 - /* fall through */ 448 448 + fallthrough; 449 449 case CEC_ST_TX_DATA_BIT_HIGH_CUSTOM: 450 450 if (tx_last_bit(pin)) { 451 451 /* Error Injection: just stop sending after this bit */ ··· 459 459 break; 460 460 } 461 461 pin->tx_bit++; 462 462 - /* fall through */ 462 462 + fallthrough; 463 463 case CEC_ST_TX_START_BIT_HIGH: 464 464 case CEC_ST_TX_START_BIT_HIGH_SHORT: 465 465 case CEC_ST_TX_START_BIT_HIGH_LONG:

+1 -1

drivers/media/cec/usb/pulse8/pulse8-cec.c

reviewed

··· 389 389 pulse8->new_rx_msg[0] = pulse8->buf[1]; 390 390 break; 391 391 } 392 392 - /* fall through */ 392 392 + fallthrough; 393 393 case MSGCODE_FRAME_DATA: 394 394 if (pulse8->new_rx_msg_len < CEC_MAX_MSG_SIZE) 395 395 pulse8->new_rx_msg[pulse8->new_rx_msg_len++] =

+1 -1

drivers/media/common/videobuf2/videobuf2-v4l2.c

reviewed

··· 601 601 break; 602 602 case VB2_BUF_STATE_ERROR: 603 603 b->flags |= V4L2_BUF_FLAG_ERROR; 604 604 - /* fall through */ 604 604 + fallthrough; 605 605 case VB2_BUF_STATE_DONE: 606 606 b->flags |= V4L2_BUF_FLAG_DONE; 607 607 break;

+1 -1

drivers/media/dvb-frontends/af9013.c

reviewed

··· 597 597 state->strength_en = 2; 598 598 break; 599 599 } 600 600 - /* Fall through */ 600 600 + fallthrough; 601 601 case 1: 602 602 if (time_is_after_jiffies(state->strength_jiffies + msecs_to_jiffies(2000))) 603 603 break;

+1 -1

drivers/media/dvb-frontends/lg2160.c

reviewed

··· 1408 1408 switch (config->lg_chip) { 1409 1409 default: 1410 1410 lg_warn("invalid chip requested, defaulting to LG2160"); 1411 1411 - /* fall-thru */ 1411 1411 + fallthrough; 1412 1412 case LG2160: 1413 1413 memcpy(&state->frontend.ops, &lg2160_ops, 1414 1414 sizeof(struct dvb_frontend_ops));

+1 -1

drivers/media/dvb-frontends/m88ds3103.c

reviewed

··· 906 906 if (ret) 907 907 goto err; 908 908 } 909 909 - /* fall through */ 909 909 + fallthrough; 910 910 default: 911 911 u16tmp = DIV_ROUND_UP(target_mclk, dev->cfg->ts_clk); 912 912 u8tmp1 = u16tmp / 2 - 1;

+1 -1

drivers/media/i2c/adv7180.c

reviewed

··· 726 726 case V4L2_FIELD_NONE: 727 727 if (state->chip_info->flags & ADV7180_FLAG_I2P) 728 728 break; 729 729 - /* fall through */ 729 729 + fallthrough; 730 730 default: 731 731 format->format.field = V4L2_FIELD_ALTERNATE; 732 732 break;

+2 -2

drivers/media/i2c/adv7511-v4l2.c

reviewed

··· 470 470 reg->val = adv7511_cec_read(sd, reg->reg & 0xff); 471 471 break; 472 472 } 473 473 - /* fall through */ 473 473 + fallthrough; 474 474 default: 475 475 v4l2_info(sd, "Register %03llx not supported\n", reg->reg); 476 476 adv7511_inv_register(sd); ··· 492 492 adv7511_cec_write(sd, reg->reg & 0xff, reg->val & 0xff); 493 493 break; 494 494 } 495 495 - /* fall through */ 495 495 + fallthrough; 496 496 default: 497 497 v4l2_info(sd, "Register %03llx not supported\n", reg->reg); 498 498 adv7511_inv_register(sd);

+1 -1

drivers/media/i2c/msp3400-kthreads.c

reviewed

··· 646 646 break; 647 647 case 0: /* 4.5 */ 648 648 state->detected_std = V4L2_STD_MN; 649 649 - /* fall-through */ 649 649 + fallthrough; 650 650 default: 651 651 no_second: 652 652 state->second = msp3400c_carrier_detect_main[max1].cdo;

+1 -1

drivers/media/i2c/ov5640.c

reviewed

··· 3010 3010 switch (rotation) { 3011 3011 case 180: 3012 3012 sensor->upside_down = true; 3013 3013 - /* fall through */ 3013 3013 + fallthrough; 3014 3014 case 0: 3015 3015 break; 3016 3016 default:

+2 -2

drivers/media/i2c/ov6650.c

reviewed

··· 685 685 switch (mf->code) { 686 686 case MEDIA_BUS_FMT_Y10_1X10: 687 687 mf->code = MEDIA_BUS_FMT_Y8_1X8; 688 688 - /* fall through */ 688 688 + fallthrough; 689 689 case MEDIA_BUS_FMT_Y8_1X8: 690 690 case MEDIA_BUS_FMT_YVYU8_2X8: 691 691 case MEDIA_BUS_FMT_YUYV8_2X8: ··· 694 694 break; 695 695 default: 696 696 mf->code = MEDIA_BUS_FMT_SBGGR8_1X8; 697 697 - /* fall through */ 697 697 + fallthrough; 698 698 case MEDIA_BUS_FMT_SBGGR8_1X8: 699 699 break; 700 700 }

+1 -1

drivers/media/i2c/ov9640.c

reviewed

··· 538 538 break; 539 539 default: 540 540 mf->code = MEDIA_BUS_FMT_UYVY8_2X8; 541 541 - /* fall through */ 541 541 + fallthrough; 542 542 case MEDIA_BUS_FMT_UYVY8_2X8: 543 543 mf->colorspace = V4L2_COLORSPACE_JPEG; 544 544 break;

+1 -1

drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c

reviewed

··· 46 46 break; 47 47 default: 48 48 v4l2_info(&state->sensor_sd, "Unknown AF status %#x\n", reg); 49 49 - /* Fall through */ 49 49 + fallthrough; 50 50 case REG_CAF_STATUS_UNFOCUSED: 51 51 case REG_AF_STATUS_UNFOCUSED: 52 52 case REG_AF_STATUS_INVALID:

+3 -3

drivers/media/i2c/smiapp/smiapp-core.c

reviewed

··· 1721 1721 sensor->binning_vertical = 1; 1722 1722 } 1723 1723 } 1724 1724 - /* Fall through */ 1724 1724 + fallthrough; 1725 1725 case V4L2_SEL_TGT_COMPOSE: 1726 1726 *crops[SMIAPP_PAD_SRC] = *comp; 1727 1727 break; ··· 2120 2120 && SMIA_LIM(sensor, SCALING_CAPABILITY) 2121 2121 != SMIAPP_SCALING_CAPABILITY_NONE) 2122 2122 return 0; 2123 2123 - /* Fall through */ 2123 2123 + fallthrough; 2124 2124 default: 2125 2125 return -EINVAL; 2126 2126 } ··· 2795 2795 case 180: 2796 2796 hwcfg->module_board_orient = 2797 2797 SMIAPP_MODULE_BOARD_ORIENT_180; 2798 2798 - /* Fall through */ 2798 2798 + fallthrough; 2799 2799 case 0: 2800 2800 break; 2801 2801 default:

+5 -5

drivers/media/i2c/tda1997x.c

reviewed

··· 2588 2588 case 36: 2589 2589 mbus_codes[i++] = MEDIA_BUS_FMT_RGB121212_1X36; 2590 2590 mbus_codes[i++] = MEDIA_BUS_FMT_YUV12_1X36; 2591 2591 - /* fall-through */ 2591 2591 + fallthrough; 2592 2592 case 24: 2593 2593 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY12_1X24; 2594 2594 break; ··· 2617 2617 mbus_codes[i++] = MEDIA_BUS_FMT_RGB888_1X24; 2618 2618 mbus_codes[i++] = MEDIA_BUS_FMT_YUV8_1X24; 2619 2619 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY12_1X24; 2620 2620 - /* fall through */ 2620 2620 + fallthrough; 2621 2621 case 20: 2622 2622 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY10_1X20; 2623 2623 - /* fall through */ 2623 2623 + fallthrough; 2624 2624 case 16: 2625 2625 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY8_1X16; 2626 2626 break; ··· 2633 2633 case 16: 2634 2634 case 12: 2635 2635 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY12_2X12; 2636 2636 - /* fall through */ 2636 2636 + fallthrough; 2637 2637 case 10: 2638 2638 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY10_2X10; 2639 2639 - /* fall through */ 2639 2639 + fallthrough; 2640 2640 case 8: 2641 2641 mbus_codes[i++] = MEDIA_BUS_FMT_UYVY8_2X8; 2642 2642 break;

+1 -1

drivers/media/i2c/tvp5150.c

reviewed

··· 293 293 switch (decoder->input) { 294 294 case TVP5150_COMPOSITE1: 295 295 input |= 2; 296 296 - /* fall through */ 296 296 + fallthrough; 297 297 case TVP5150_COMPOSITE0: 298 298 break; 299 299 case TVP5150_SVIDEO:

+1 -1

drivers/media/pci/bt8xx/bttv-driver.c

reviewed

··· 2332 2332 field = V4L2_FIELD_SEQ_TB; 2333 2333 break; 2334 2334 } 2335 2335 - /* fall through */ 2335 2335 + fallthrough; 2336 2336 default: /* FIELD_ANY case */ 2337 2337 height2 = btv->crop[!!fh->do_crop].rect.height >> 1; 2338 2338 field = (f->fmt.pix.height > height2)

+1 -1

drivers/media/pci/cx88/cx88-cards.c

reviewed

··· 3499 3499 cx_clear(MO_GP0_IO, 0x00000040); 3500 3500 msleep(1000); 3501 3501 cx_set(MO_GP0_IO, 0x00004040); 3502 3502 - /* FALLTHROUGH */ 3502 3502 + fallthrough; 3503 3503 case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T1: 3504 3504 case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_PLUS: 3505 3505 case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_HYBRID:

+1 -1

drivers/media/pci/cx88/cx88-video.c

reviewed

··· 1385 1385 request_module("rtc-isl1208"); 1386 1386 core->i2c_rtc = i2c_new_client_device(&core->i2c_adap, &rtc_info); 1387 1387 } 1388 1388 - /* fall-through */ 1388 1388 + fallthrough; 1389 1389 case CX88_BOARD_DVICO_FUSIONHDTV_5_PCI_NANO: 1390 1390 request_module("ir-kbd-i2c"); 1391 1391 }

+2 -2

drivers/media/pci/saa7134/saa7134-cards.c

reviewed

··· 7812 7812 dev->name, saa7134_boards[dev->board].name); 7813 7813 break; 7814 7814 } 7815 7815 - /* fall-through */ 7815 7815 + fallthrough; 7816 7816 case SAA7134_BOARD_VIDEOMATE_DVBT_300: 7817 7817 case SAA7134_BOARD_ASUS_EUROPA2_HYBRID: 7818 7818 case SAA7134_BOARD_ASUS_EUROPA_HYBRID: ··· 7870 7870 break; 7871 7871 case SAA7134_BOARD_HAUPPAUGE_HVR1110: 7872 7872 hauppauge_eeprom(dev, dev->eedata+0x80); 7873 7873 - /* fall-through */ 7873 7873 + fallthrough; 7874 7874 case SAA7134_BOARD_PINNACLE_PCTV_310i: 7875 7875 case SAA7134_BOARD_KWORLD_DVBT_210: 7876 7876 case SAA7134_BOARD_TEVION_DVBT_220RF:

+1 -1

drivers/media/pci/solo6x10/solo6x10-core.c

reviewed

··· 503 503 default: 504 504 dev_warn(&pdev->dev, "Invalid chip_id 0x%02x, assuming 4 ch\n", 505 505 chip_id); 506 506 - /* fall through */ 506 506 + fallthrough; 507 507 case 5: 508 508 solo_dev->nr_chans = 4; 509 509 solo_dev->nr_ext = 1;

+1 -1

drivers/media/pci/solo6x10/solo6x10-i2c.c

reviewed

··· 183 183 } 184 184 185 185 solo_dev->i2c_state = IIC_STATE_WRITE; 186 186 - /* fall through */ 186 186 + fallthrough; 187 187 case IIC_STATE_WRITE: 188 188 ret = solo_i2c_handle_write(solo_dev); 189 189 break;

+2 -2

drivers/media/platform/coda/coda-bit.c

reviewed

··· 1101 1101 break; 1102 1102 case CODA_960: 1103 1103 coda_write(dev, 0, CODA9_GDI_WPROT_RGN_EN); 1104 1104 - /* fallthrough */ 1104 1104 + fallthrough; 1105 1105 case CODA_HX4: 1106 1106 case CODA_7541: 1107 1107 coda_write(dev, CODA7_STREAM_BUF_DYNALLOC_EN | ··· 1141 1141 CODA7_PICHEIGHT_MASK) << CODA_PICHEIGHT_OFFSET; 1142 1142 break; 1143 1143 } 1144 1144 - /* fallthrough */ 1144 1144 + fallthrough; 1145 1145 case CODA_960: 1146 1146 value = (q_data_src->rect.width & CODA7_PICWIDTH_MASK) 1147 1147 << CODA7_PICWIDTH_OFFSET;

+5 -5

drivers/media/platform/coda/coda-common.c

reviewed

··· 808 808 ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP; 809 809 break; 810 810 } 811 811 - /* else fall through */ 811 811 + fallthrough; 812 812 case V4L2_PIX_FMT_YUV420: 813 813 case V4L2_PIX_FMT_YVU420: 814 814 case V4L2_PIX_FMT_YUV422P: ··· 1015 1015 case V4L2_SEL_TGT_CROP_DEFAULT: 1016 1016 case V4L2_SEL_TGT_CROP_BOUNDS: 1017 1017 rsel = &r; 1018 1018 - /* fallthrough */ 1018 1018 + fallthrough; 1019 1019 case V4L2_SEL_TGT_CROP: 1020 1020 if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT || 1021 1021 ctx->inst_type == CODA_INST_DECODER) ··· 1024 1024 case V4L2_SEL_TGT_COMPOSE_BOUNDS: 1025 1025 case V4L2_SEL_TGT_COMPOSE_PADDED: 1026 1026 rsel = &r; 1027 1027 - /* fallthrough */ 1027 1027 + fallthrough; 1028 1028 case V4L2_SEL_TGT_COMPOSE: 1029 1029 case V4L2_SEL_TGT_COMPOSE_DEFAULT: 1030 1030 if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE || ··· 1074 1074 1075 1075 return 0; 1076 1076 } 1077 1077 - /* else fall through */ 1077 1077 + fallthrough; 1078 1078 case V4L2_SEL_TGT_NATIVE_SIZE: 1079 1079 case V4L2_SEL_TGT_COMPOSE: 1080 1080 return coda_g_selection(file, fh, s); ··· 2628 2628 */ 2629 2629 if (enable_bwb || ctx->inst_type == CODA_INST_ENCODER) 2630 2630 ctx->frame_mem_ctrl = CODA9_FRAME_ENABLE_BWB; 2631 2631 - /* fallthrough */ 2631 2631 + fallthrough; 2632 2632 case CODA_HX4: 2633 2633 case CODA_7541: 2634 2634 ctx->reg_idx = 0;

+3 -3

drivers/media/platform/exynos4-is/fimc-capture.c

reviewed

··· 1279 1279 case V4L2_SEL_TGT_COMPOSE_DEFAULT: 1280 1280 case V4L2_SEL_TGT_COMPOSE_BOUNDS: 1281 1281 f = &ctx->d_frame; 1282 1282 - /* fall through */ 1282 1282 + fallthrough; 1283 1283 case V4L2_SEL_TGT_CROP_BOUNDS: 1284 1284 case V4L2_SEL_TGT_CROP_DEFAULT: 1285 1285 s->r.left = 0; ··· 1290 1290 1291 1291 case V4L2_SEL_TGT_COMPOSE: 1292 1292 f = &ctx->d_frame; 1293 1293 - /* fall through */ 1293 1293 + fallthrough; 1294 1294 case V4L2_SEL_TGT_CROP: 1295 1295 s->r.left = f->offs_h; 1296 1296 s->r.top = f->offs_v; ··· 1601 1601 switch (sel->target) { 1602 1602 case V4L2_SEL_TGT_COMPOSE_BOUNDS: 1603 1603 f = &ctx->d_frame; 1604 1604 - /* fall through */ 1604 1604 + fallthrough; 1605 1605 case V4L2_SEL_TGT_CROP_BOUNDS: 1606 1606 r->width = f->o_width; 1607 1607 r->height = f->o_height;

+1 -1

drivers/media/platform/exynos4-is/fimc-reg.c

reviewed

··· 710 710 break; 711 711 case FIMC_BUS_TYPE_LCD_WRITEBACK_A: 712 712 cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB; 713 713 - /* fall through */ 713 713 + fallthrough; 714 714 case FIMC_BUS_TYPE_ISP_WRITEBACK: 715 715 if (fimc->variant->has_isp_wb) 716 716 cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB;

+1 -1

drivers/media/platform/exynos4-is/media-dev.c

reviewed

··· 93 93 switch (sd->grp_id) { 94 94 case GRP_ID_SENSOR: 95 95 sensor = sd; 96 96 - /* fall through */ 96 96 + fallthrough; 97 97 case GRP_ID_FIMC_IS_SENSOR: 98 98 p->subdevs[IDX_SENSOR] = sd; 99 99 break;

+1 -1

drivers/media/platform/marvell-ccic/mcam-core.c

reviewed

··· 389 389 dma_free_coherent(cam->dev, cam->dma_buf_size, 390 390 cam->dma_bufs[0], cam->dma_handles[0]); 391 391 cam->nbufs = 0; 392 392 - /* fall-through */ 392 392 + fallthrough; 393 393 case 0: 394 394 cam_err(cam, "Insufficient DMA buffers, cannot operate\n"); 395 395 return -ENOMEM;

+1 -1

drivers/media/platform/omap3isp/ispvideo.c

reviewed

··· 703 703 * requested. 704 704 */ 705 705 format->fmt.pix.field = V4L2_FIELD_INTERLACED_TB; 706 706 - /* Fall-through */ 706 706 + fallthrough; 707 707 case V4L2_FIELD_INTERLACED_TB: 708 708 case V4L2_FIELD_INTERLACED_BT: 709 709 /* Interlaced orders are only supported at the CCDC output. */

+1 -1

drivers/media/platform/qcom/venus/vdec.c

reviewed

··· 1072 1072 switch (inst->codec_state) { 1073 1073 case VENUS_DEC_STATE_DECODING: 1074 1074 ret = hfi_session_flush(inst, HFI_FLUSH_ALL, true); 1075 1075 - /* fallthrough */ 1075 1075 + fallthrough; 1076 1076 case VENUS_DEC_STATE_DRAIN: 1077 1077 vdec_cancel_dst_buffers(inst); 1078 1078 inst->codec_state = VENUS_DEC_STATE_STOPPED;

+2 -2

drivers/media/platform/renesas-ceu.c

reviewed

··· 405 405 /* Non-swapped planar image capture mode. */ 406 406 case V4L2_PIX_FMT_NV16: 407 407 cdocr |= CEU_CDOCR_NO_DOWSAMPLE; 408 408 - /* fall-through */ 408 408 + fallthrough; 409 409 case V4L2_PIX_FMT_NV12: 410 410 if (mbus_fmt->swapped) 411 411 camcr = mbus_fmt->fmt_order_swap; ··· 419 419 /* Swapped planar image capture mode. */ 420 420 case V4L2_PIX_FMT_NV61: 421 421 cdocr |= CEU_CDOCR_NO_DOWSAMPLE; 422 422 - /* fall-through */ 422 422 + fallthrough; 423 423 case V4L2_PIX_FMT_NV21: 424 424 if (mbus_fmt->swapped) 425 425 camcr = mbus_fmt->fmt_order;

+1 -1

drivers/media/radio/si4713/si4713.c

reviewed

··· 1157 1157 * V4L2_CID_TUNE_POWER_LEVEL. */ 1158 1158 if (force) 1159 1159 break; 1160 1160 - /* fall through */ 1160 1160 + fallthrough; 1161 1161 case V4L2_CID_TUNE_POWER_LEVEL: 1162 1162 ret = si4713_tx_tune_power(sdev, 1163 1163 sdev->tune_pwr_level->val, sdev->tune_ant_cap->val);

+1 -1

drivers/media/rc/iguanair.c

reviewed

··· 101 101 break; 102 102 case CMD_TX_OVERFLOW: 103 103 ir->tx_overflow = true; 104 104 - /* fall through */ 104 104 + fallthrough; 105 105 case CMD_RECEIVER_OFF: 106 106 case CMD_RECEIVER_ON: 107 107 case CMD_SEND:

+1 -1

drivers/media/test-drivers/vicodec/vicodec-core.c

reviewed

··· 1310 1310 case V4L2_EVENT_SOURCE_CHANGE: 1311 1311 if (ctx->is_enc) 1312 1312 return -EINVAL; 1313 1313 - /* fall through */ 1313 1313 + fallthrough; 1314 1314 case V4L2_EVENT_EOS: 1315 1315 if (ctx->is_stateless) 1316 1316 return -EINVAL;

+1 -1

drivers/media/test-drivers/vivid/vivid-vbi-gen.c

reviewed

··· 298 298 switch (frame) { 299 299 case 0: 300 300 vivid_vbi_gen_set_time_of_day(vbi->time_of_day_packet); 301 301 - /* fall through */ 301 301 + fallthrough; 302 302 case 1 ... 7: 303 303 data1->data[0] = vbi->time_of_day_packet[frame * 2]; 304 304 data1->data[1] = vbi->time_of_day_packet[frame * 2 + 1];

+1 -1

drivers/media/tuners/fc0011.c

reviewed

··· 250 250 dev_warn(&priv->i2c->dev, "Unsupported bandwidth %u kHz. Using 6000 kHz.\n", 251 251 bandwidth); 252 252 bandwidth = 6000; 253 253 - /* fallthrough */ 253 253 + fallthrough; 254 254 case 6000: 255 255 regs[FC11_REG_VCOSEL] |= FC11_VCOSEL_BW6M; 256 256 break;

+1 -1

drivers/media/tuners/tda18271-fe.c

reviewed

··· 948 948 break; 949 949 case SYS_DVBC_ANNEX_B: 950 950 bw = 6000000; 951 951 - /* fall through */ 951 951 + fallthrough; 952 952 case SYS_DVBC_ANNEX_A: 953 953 case SYS_DVBC_ANNEX_C: 954 954 if (bw <= 6000000) {

+1 -1

drivers/media/usb/dvb-usb-v2/af9015.c

reviewed

··· 43 43 case READ_I2C: 44 44 write = 0; 45 45 state->buf[2] |= 0x01; /* set I2C direction */ 46 46 - /* fall through */ 46 46 + fallthrough; 47 47 case WRITE_I2C: 48 48 state->buf[0] = READ_WRITE_I2C; 49 49 break;

+1 -1

drivers/media/usb/dvb-usb-v2/gl861.c

reviewed

··· 41 41 switch (request) { 42 42 case CMD_WRITE: 43 43 memcpy(ctx->buf, data, size); 44 44 - /* Fall through */ 44 44 + fallthrough; 45 45 case CMD_WRITE_SHORT: 46 46 pipe = usb_sndctrlpipe(d->udev, 0); 47 47 requesttype = USB_TYPE_VENDOR | USB_DIR_OUT;

+4 -4

drivers/media/usb/dvb-usb-v2/lmedm04.c

reviewed

··· 687 687 cold = 0; 688 688 break; 689 689 } 690 690 - /* fall through */ 690 690 + fallthrough; 691 691 case TUNER_LG: 692 692 fw_lme = fw_lg; 693 693 ret = request_firmware(&fw, fw_lme, &udev->dev); ··· 710 710 cold = 0; 711 711 break; 712 712 } 713 713 - /* fall through */ 713 713 + fallthrough; 714 714 case TUNER_LG: 715 715 fw_lme = fw_c_lg; 716 716 ret = request_firmware(&fw, fw_lme, &udev->dev); ··· 718 718 st->dvb_usb_lme2510_firmware = TUNER_LG; 719 719 break; 720 720 } 721 721 - /* fall through */ 721 721 + fallthrough; 722 722 case TUNER_S0194: 723 723 fw_lme = fw_c_s0194; 724 724 ret = request_firmware(&fw, fw_lme, &udev->dev); ··· 1018 1018 } 1019 1019 break; 1020 1020 } 1021 1021 - /* fall through */ 1021 1021 + fallthrough; 1022 1022 case 0x22f0: 1023 1023 st->i2c_gate = 5; 1024 1024 adap->fe[0] = dvb_attach(m88rs2000_attach,

+2 -2

drivers/media/usb/dvb-usb-v2/mxl111sf-gpio.c

reviewed

··· 632 632 default: 633 633 mxl_printk(KERN_ERR, 634 634 "gpio_port_expander undefined, assuming PCA9534"); 635 635 - /* fall-thru */ 635 635 + fallthrough; 636 636 case mxl111sf_PCA9534: 637 637 return pca9534_set_gpio(state, gpio, val); 638 638 case mxl111sf_gpio_hw: ··· 693 693 default: 694 694 mxl_printk(KERN_ERR, 695 695 "gpio_port_expander undefined, assuming PCA9534"); 696 696 - /* fall-thru */ 696 696 + fallthrough; 697 697 case mxl111sf_PCA9534: 698 698 return pca9534_init_port_expander(state); 699 699 case mxl111sf_gpio_hw:

+4 -4

drivers/media/usb/em28xx/em28xx-audio.c

reviewed

··· 362 362 return -ENODEV; 363 363 364 364 switch (cmd) { 365 365 - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: /* fall through */ 366 366 - case SNDRV_PCM_TRIGGER_RESUME: /* fall through */ 365 365 + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 366 366 + case SNDRV_PCM_TRIGGER_RESUME: 367 367 case SNDRV_PCM_TRIGGER_START: 368 368 atomic_set(&dev->adev.stream_started, 1); 369 369 break; 370 370 - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: /* fall through */ 371 371 - case SNDRV_PCM_TRIGGER_SUSPEND: /* fall through */ 370 370 + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 371 371 + case SNDRV_PCM_TRIGGER_SUSPEND: 372 372 case SNDRV_PCM_TRIGGER_STOP: 373 373 atomic_set(&dev->adev.stream_started, 0); 374 374 break;

+1 -1

drivers/media/usb/go7007/go7007-driver.c

reviewed

··· 643 643 case 0xD8: 644 644 if (go->format == V4L2_PIX_FMT_MJPEG) 645 645 vb = frame_boundary(go, vb); 646 646 - /* fall through */ 646 646 + fallthrough; 647 647 default: 648 648 store_byte(vb, 0xFF); 649 649 store_byte(vb, buf[i]);

+5 -5

drivers/media/usb/gspca/mr97310a.c

reviewed

··· 510 510 switch (gspca_dev->pixfmt.width) { 511 511 case 160: 512 512 data[9] |= 0x04; /* reg 8, 2:1 scale down from 320 */ 513 513 - /* fall through */ 513 513 + fallthrough; 514 514 case 320: 515 515 default: 516 516 data[3] = 0x28; /* reg 2, H size/8 */ ··· 520 520 break; 521 521 case 176: 522 522 data[9] |= 0x04; /* reg 8, 2:1 scale down from 352 */ 523 523 - /* fall through */ 523 523 + fallthrough; 524 524 case 352: 525 525 data[3] = 0x2c; /* reg 2, H size/8 */ 526 526 data[4] = 0x48; /* reg 3, V size/4 */ ··· 607 607 switch (gspca_dev->pixfmt.width) { 608 608 case 160: 609 609 data[9] |= 0x0c; /* reg 8, 4:1 scale down */ 610 610 - /* fall through */ 610 610 + fallthrough; 611 611 case 320: 612 612 data[9] |= 0x04; /* reg 8, 2:1 scale down */ 613 613 - /* fall through */ 613 613 + fallthrough; 614 614 case 640: 615 615 default: 616 616 data[3] = 0x50; /* reg 2, H size/8 */ ··· 627 627 628 628 case 176: 629 629 data[9] |= 0x04; /* reg 8, 2:1 scale down */ 630 630 - /* fall through */ 630 630 + fallthrough; 631 631 case 352: 632 632 data[3] = 0x2c; /* reg 2, H size */ 633 633 data[4] = 0x48; /* reg 3, V size */

+1 -1

drivers/media/usb/gspca/nw80x.c

reviewed

··· 2019 2019 V4L2_CID_AUTOGAIN, 0, 1, 1, 1); 2020 2020 gspca_dev->gain = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops, 2021 2021 V4L2_CID_GAIN, 0, 253, 1, 128); 2022 2022 - /* fall through */ 2022 2022 + fallthrough; 2023 2023 case Cvideopro: 2024 2024 case DvcV6: 2025 2025 case Kritter:

+3 -3

drivers/media/usb/gspca/ov519.c

reviewed

··· 2004 2004 break; 2005 2005 case BRIDGE_OVFX2: 2006 2006 req = 0x0a; 2007 2007 - /* fall through */ 2007 2007 + fallthrough; 2008 2008 case BRIDGE_W9968CF: 2009 2009 gspca_dbg(gspca_dev, D_USBO, "SET %02x %04x %04x\n", 2010 2010 req, value, index); ··· 3528 3528 case SEN_OV76BE: 3529 3529 if (sd->gspca_dev.pixfmt.width == 320) 3530 3530 interlaced = 1; 3531 3531 - /* Fall through */ 3531 3531 + fallthrough; 3532 3532 case SEN_OV6630: 3533 3533 case SEN_OV7610: 3534 3534 case SEN_OV7670: ··· 3541 3541 break; 3542 3542 } 3543 3543 /* For 640x480 case */ 3544 3544 - /* fall through */ 3544 3544 + fallthrough; 3545 3545 default: 3546 3546 /* case 20: */ 3547 3547 /* case 15: */

+1 -1

drivers/media/usb/gspca/sn9c20x.c

reviewed

··· 1637 1637 break; 1638 1638 case SENSOR_HV7131R: 1639 1639 sd->i2c_intf = 0x81; /* i2c 400 Kb/s */ 1640 1640 - /* fall through */ 1640 1640 + fallthrough; 1641 1641 default: 1642 1642 cam->cam_mode = vga_mode; 1643 1643 cam->nmodes = ARRAY_SIZE(vga_mode);

+2 -2

drivers/media/usb/gspca/sunplus.c

reviewed

··· 551 551 case BRIDGE_SPCA504: 552 552 case BRIDGE_SPCA504C: 553 553 pollreg = 0; 554 554 - /* fall through */ 554 554 + fallthrough; 555 555 default: 556 556 /* case BRIDGE_SPCA533: */ 557 557 /* case BRIDGE_SPCA504B: */ ··· 634 634 reg_w_riv(gspca_dev, 0x00, 0x2000, 0x00); 635 635 reg_w_riv(gspca_dev, 0x00, 0x2301, 0x13); 636 636 reg_w_riv(gspca_dev, 0x00, 0x2306, 0x00); 637 637 - /* fall through */ 637 637 + fallthrough; 638 638 case BRIDGE_SPCA533: 639 639 spca504B_PollingDataReady(gspca_dev); 640 640 spca50x_GetFirmware(gspca_dev);

+2 -2

drivers/media/usb/gspca/xirlink_cit.c

reviewed

··· 1409 1409 case CIT_MODEL0: 1410 1410 case CIT_MODEL1: 1411 1411 cit_write_reg(gspca_dev, 0x0001, 0x0114); 1412 1412 - /* Fall through */ 1412 1412 + fallthrough; 1413 1413 case CIT_MODEL2: 1414 1414 case CIT_MODEL4: 1415 1415 cit_write_reg(gspca_dev, 0x00c0, 0x010c); /* Go! */ ··· 2725 2725 break; 2726 2726 case CIT_MODEL2: 2727 2727 v4l2_ctrl_grab(sd->lighting, false); 2728 2728 - /* Fall through! */ 2728 2728 + fallthrough; 2729 2729 case CIT_MODEL4: 2730 2730 cit_model2_Packet1(gspca_dev, 0x0030, 0x0004); 2731 2731

+2 -2

drivers/media/usb/gspca/zc3xx.c

reviewed

··· 6766 6766 case SENSOR_HV7131R: 6767 6767 case SENSOR_TAS5130C: 6768 6768 reg_r(gspca_dev, 0x0008); 6769 6769 - /* fall through */ 6769 6769 + fallthrough; 6770 6770 case SENSOR_PO2030: 6771 6771 reg_w(gspca_dev, 0x03, 0x0008); 6772 6772 break; ··· 6815 6815 case SENSOR_TAS5130C: 6816 6816 reg_w(gspca_dev, 0x09, 0x01ad); /* (from win traces) */ 6817 6817 reg_w(gspca_dev, 0x15, 0x01ae); 6818 6818 - /* fall through */ 6818 6818 + fallthrough; 6819 6819 case SENSOR_PAS202B: 6820 6820 case SENSOR_PO2030: 6821 6821 /* reg_w(gspca_dev, 0x40, ZC3XX_R117_GGAIN); in win traces */

+1 -1

drivers/media/usb/pwc/pwc-v4l.c

reviewed

··· 554 554 if (!DEVICE_USE_CODEC3(pdev->type)) 555 555 break; 556 556 /* For CODEC3 where autogain also controls expo */ 557 557 - /* fall through */ 557 557 + fallthrough; 558 558 case V4L2_CID_EXPOSURE_AUTO: 559 559 if (pdev->exposure_valid && time_before(jiffies, 560 560 pdev->last_exposure_update + HZ / 4)) {

+1 -1

drivers/media/usb/siano/smsusb.c

reviewed

··· 430 430 break; 431 431 case SMS_UNKNOWN_TYPE: 432 432 pr_err("Unspecified sms device type!\n"); 433 433 - /* fall-thru */ 433 433 + fallthrough; 434 434 default: 435 435 dev->buffer_size = USB2_BUFFER_SIZE; 436 436 dev->response_alignment = align;

+4 -4

drivers/media/usb/tm6000/tm6000-alsa.c

reviewed

··· 272 272 int err = 0; 273 273 274 274 switch (cmd) { 275 275 - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: /* fall through */ 276 276 - case SNDRV_PCM_TRIGGER_RESUME: /* fall through */ 275 275 + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 276 276 + case SNDRV_PCM_TRIGGER_RESUME: 277 277 case SNDRV_PCM_TRIGGER_START: 278 278 atomic_set(&core->stream_started, 1); 279 279 break; 280 280 - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: /* fall through */ 281 281 - case SNDRV_PCM_TRIGGER_SUSPEND: /* fall through */ 280 280 + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 281 281 + case SNDRV_PCM_TRIGGER_SUSPEND: 282 282 case SNDRV_PCM_TRIGGER_STOP: 283 283 atomic_set(&core->stream_started, 0); 284 284 break;

+2 -2

drivers/media/usb/uvc/uvc_video.c

reviewed

··· 1509 1509 default: 1510 1510 uvc_printk(KERN_WARNING, "Non-zero status (%d) in video " 1511 1511 "completion handler.\n", urb->status); 1512 1512 - /* fall through */ 1512 1512 + fallthrough; 1513 1513 case -ENOENT: /* usb_poison_urb() called. */ 1514 1514 if (stream->frozen) 1515 1515 return; 1516 1516 - /* fall through */ 1516 1516 + fallthrough; 1517 1517 case -ECONNRESET: /* usb_unlink_urb() called. */ 1518 1518 case -ESHUTDOWN: /* The endpoint is being disabled. */ 1519 1519 uvc_queue_cancel(queue, urb->status == -ESHUTDOWN);