Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: ti: make clk-dra7-atl explicitly non-modular

The Kconfig currently controlling compilation of this code is:

arch/arm/mach-omap2/Kconfig:config SOC_DRA7XX
arch/arm/mach-omap2/Kconfig: bool "TI DRA7XX"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tags etc. since all that information
is already contained at the top of the file in the comments.

Cc: Tero Kristo <t-kristo@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-omap@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

authored by

Paul Gortmaker and committed by
Stephen Boyd
172ff5a2 33996b02

+3 -17
+3 -17
drivers/clk/ti/clk-dra7-atl.c
··· 15 15 * GNU General Public License for more details. 16 16 */ 17 17 18 - #include <linux/module.h> 18 + #include <linux/init.h> 19 19 #include <linux/clk.h> 20 20 #include <linux/clk-provider.h> 21 21 #include <linux/slab.h> ··· 295 295 return ret; 296 296 } 297 297 298 - static int of_dra7_atl_clk_remove(struct platform_device *pdev) 299 - { 300 - pm_runtime_disable(&pdev->dev); 301 - 302 - return 0; 303 - } 304 - 305 298 static const struct of_device_id of_dra7_atl_clk_match_tbl[] = { 306 299 { .compatible = "ti,dra7-atl", }, 307 300 {}, 308 301 }; 309 - MODULE_DEVICE_TABLE(of, of_dra7_atl_clk_match_tbl); 310 302 311 303 static struct platform_driver dra7_atl_clk_driver = { 312 304 .driver = { 313 305 .name = "dra7-atl", 306 + .suppress_bind_attrs = true, 314 307 .of_match_table = of_dra7_atl_clk_match_tbl, 315 308 }, 316 309 .probe = of_dra7_atl_clk_probe, 317 - .remove = of_dra7_atl_clk_remove, 318 310 }; 319 - 320 - module_platform_driver(dra7_atl_clk_driver); 321 - 322 - MODULE_DESCRIPTION("Clock driver for DRA7 Audio Tracking Logic"); 323 - MODULE_ALIAS("platform:dra7-atl-clock"); 324 - MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>"); 325 - MODULE_LICENSE("GPL v2"); 311 + builtin_platform_driver(dra7_atl_clk_driver);