Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: rockchip - use devm_add_action_or_reset()

If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated. Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Sudip Mukherjee and committed by
Herbert Xu
16d56963 e09287df

+2 -4
+2 -4
drivers/crypto/rockchip/rk3288_crypto.c
··· 304 304 usleep_range(10, 20); 305 305 reset_control_deassert(crypto_info->rst); 306 306 307 - err = devm_add_action(dev, rk_crypto_action, crypto_info); 308 - if (err) { 309 - reset_control_assert(crypto_info->rst); 307 + err = devm_add_action_or_reset(dev, rk_crypto_action, crypto_info); 308 + if (err) 310 309 goto err_crypto; 311 - } 312 310 313 311 spin_lock_init(&crypto_info->lock); 314 312