Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: switch to netif_napi_add_tx()

Switch net callers to the new API not requiring
the NAPI_POLL_WEIGHT argument.

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Acked-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Link: https://lore.kernel.org/r/20220504163725.550782-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+29 -40
+1 -1
drivers/net/ethernet/broadcom/bcm4908_enet.c
··· 722 722 netdev->min_mtu = ETH_ZLEN; 723 723 netdev->mtu = ETH_DATA_LEN; 724 724 netdev->max_mtu = ENET_MTU_MAX; 725 - netif_tx_napi_add(netdev, &enet->tx_ring.napi, bcm4908_enet_poll_tx, NAPI_POLL_WEIGHT); 725 + netif_napi_add_tx(netdev, &enet->tx_ring.napi, bcm4908_enet_poll_tx); 726 726 netif_napi_add(netdev, &enet->rx_ring.napi, bcm4908_enet_poll_rx, NAPI_POLL_WEIGHT); 727 727 728 728 err = register_netdev(netdev);
+1 -1
drivers/net/ethernet/broadcom/bcmsysport.c
··· 1517 1517 /* Initialize SW view of the ring */ 1518 1518 spin_lock_init(&ring->lock); 1519 1519 ring->priv = priv; 1520 - netif_tx_napi_add(priv->netdev, &ring->napi, bcm_sysport_tx_poll, 64); 1520 + netif_napi_add_tx(priv->netdev, &ring->napi, bcm_sysport_tx_poll); 1521 1521 ring->index = index; 1522 1522 ring->size = size; 1523 1523 ring->clean_index = 0;
+1 -2
drivers/net/ethernet/broadcom/genet/bcmgenet.c
··· 2671 2671 DMA_END_ADDR); 2672 2672 2673 2673 /* Initialize Tx NAPI */ 2674 - netif_tx_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll, 2675 - NAPI_POLL_WEIGHT); 2674 + netif_napi_add_tx(priv->dev, &ring->napi, bcmgenet_tx_poll); 2676 2675 } 2677 2676 2678 2677 /* Initialize a RDMA ring */
+1 -2
drivers/net/ethernet/fungible/funeth/funeth_main.c
··· 330 330 return PTR_ERR(irq); 331 331 332 332 fp->num_tx_irqs++; 333 - netif_tx_napi_add(dev, &irq->napi, fun_txq_napi_poll, 334 - NAPI_POLL_WEIGHT); 333 + netif_napi_add_tx(dev, &irq->napi, fun_txq_napi_poll); 335 334 } 336 335 337 336 for (i = fp->num_rx_irqs; i < nrx; i++) {
+2 -2
drivers/net/ethernet/lantiq_xrx200.c
··· 615 615 /* setup NAPI */ 616 616 netif_napi_add(net_dev, &priv->chan_rx.napi, xrx200_poll_rx, 617 617 NAPI_POLL_WEIGHT); 618 - netif_tx_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping, 619 - NAPI_POLL_WEIGHT); 618 + netif_napi_add_tx(net_dev, &priv->chan_tx.napi, 619 + xrx200_tx_housekeeping); 620 620 621 621 platform_set_drvdata(pdev, priv); 622 622
+1 -2
drivers/net/ethernet/mellanox/mlx4/en_cq.c
··· 147 147 switch (cq->type) { 148 148 case TX: 149 149 cq->mcq.comp = mlx4_en_tx_irq; 150 - netif_tx_napi_add(cq->dev, &cq->napi, mlx4_en_poll_tx_cq, 151 - NAPI_POLL_WEIGHT); 150 + netif_napi_add_tx(cq->dev, &cq->napi, mlx4_en_poll_tx_cq); 152 151 napi_enable(&cq->napi); 153 152 break; 154 153 case RX:
+1 -1
drivers/net/ethernet/microsoft/mana/mana_en.c
··· 1371 1371 1372 1372 gc->cq_table[cq->gdma_id] = cq->gdma_cq; 1373 1373 1374 - netif_tx_napi_add(net, &cq->napi, mana_poll, NAPI_POLL_WEIGHT); 1374 + netif_napi_add_tx(net, &cq->napi, mana_poll); 1375 1375 napi_enable(&cq->napi); 1376 1376 1377 1377 mana_gd_ring_cq(cq->gdma_cq, SET_ARM_BIT);
+4 -5
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
··· 1608 1608 if (qlcnic_check_multi_tx(adapter) && !adapter->ahw->diag_test) { 1609 1609 for (ring = 0; ring < adapter->drv_tx_rings; ring++) { 1610 1610 tx_ring = &adapter->tx_ring[ring]; 1611 - netif_tx_napi_add(netdev, &tx_ring->napi, qlcnic_tx_poll, 1612 - NAPI_POLL_WEIGHT); 1611 + netif_napi_add_tx(netdev, &tx_ring->napi, 1612 + qlcnic_tx_poll); 1613 1613 } 1614 1614 } 1615 1615 ··· 2138 2138 !(adapter->flags & QLCNIC_TX_INTR_SHARED)) { 2139 2139 for (ring = 0; ring < adapter->drv_tx_rings; ring++) { 2140 2140 tx_ring = &adapter->tx_ring[ring]; 2141 - netif_tx_napi_add(netdev, &tx_ring->napi, 2142 - qlcnic_83xx_msix_tx_poll, 2143 - NAPI_POLL_WEIGHT); 2141 + netif_napi_add_tx(netdev, &tx_ring->napi, 2142 + qlcnic_83xx_msix_tx_poll); 2144 2143 } 2145 2144 } 2146 2145
+1 -2
drivers/net/ethernet/rocker/rocker_main.c
··· 2573 2573 rocker_port_dev_addr_init(rocker_port); 2574 2574 dev->netdev_ops = &rocker_port_netdev_ops; 2575 2575 dev->ethtool_ops = &rocker_port_ethtool_ops; 2576 - netif_tx_napi_add(dev, &rocker_port->napi_tx, rocker_port_poll_tx, 2577 - NAPI_POLL_WEIGHT); 2576 + netif_napi_add_tx(dev, &rocker_port->napi_tx, rocker_port_poll_tx); 2578 2577 netif_napi_add(dev, &rocker_port->napi_rx, rocker_port_poll_rx, 2579 2578 NAPI_POLL_WEIGHT); 2580 2579 rocker_carrier_init(rocker_port);
+1 -2
drivers/net/ethernet/socionext/sni_ave.c
··· 1689 1689 /* Register as a NAPI supported driver */ 1690 1690 netif_napi_add(ndev, &priv->napi_rx, ave_napi_poll_rx, 1691 1691 NAPI_POLL_WEIGHT); 1692 - netif_tx_napi_add(ndev, &priv->napi_tx, ave_napi_poll_tx, 1693 - NAPI_POLL_WEIGHT); 1692 + netif_napi_add_tx(ndev, &priv->napi_tx, ave_napi_poll_tx); 1694 1693 1695 1694 platform_set_drvdata(pdev, ndev); 1696 1695
+2 -3
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
··· 6759 6759 NAPI_POLL_WEIGHT); 6760 6760 } 6761 6761 if (queue < priv->plat->tx_queues_to_use) { 6762 - netif_tx_napi_add(dev, &ch->tx_napi, 6763 - stmmac_napi_poll_tx, 6764 - NAPI_POLL_WEIGHT); 6762 + netif_napi_add_tx(dev, &ch->tx_napi, 6763 + stmmac_napi_poll_tx); 6765 6764 } 6766 6765 if (queue < priv->plat->rx_queues_to_use && 6767 6766 queue < priv->plat->tx_queues_to_use) {
+2 -2
drivers/net/ethernet/ti/am65-cpsw-nuss.c
··· 2032 2032 for (i = 0; i < common->tx_ch_num; i++) { 2033 2033 struct am65_cpsw_tx_chn *tx_chn = &common->tx_chns[i]; 2034 2034 2035 - netif_tx_napi_add(common->dma_ndev, &tx_chn->napi_tx, 2036 - am65_cpsw_nuss_tx_poll, NAPI_POLL_WEIGHT); 2035 + netif_napi_add_tx(common->dma_ndev, &tx_chn->napi_tx, 2036 + am65_cpsw_nuss_tx_poll); 2037 2037 2038 2038 ret = devm_request_irq(dev, tx_chn->irq, 2039 2039 am65_cpsw_nuss_tx_irq,
+2 -3
drivers/net/ethernet/ti/cpsw.c
··· 1640 1640 netif_napi_add(ndev, &cpsw->napi_rx, 1641 1641 cpsw->quirk_irq ? cpsw_rx_poll : cpsw_rx_mq_poll, 1642 1642 NAPI_POLL_WEIGHT); 1643 - netif_tx_napi_add(ndev, &cpsw->napi_tx, 1644 - cpsw->quirk_irq ? cpsw_tx_poll : cpsw_tx_mq_poll, 1645 - NAPI_POLL_WEIGHT); 1643 + netif_napi_add_tx(ndev, &cpsw->napi_tx, 1644 + cpsw->quirk_irq ? cpsw_tx_poll : cpsw_tx_mq_poll); 1646 1645 1647 1646 /* register the network device */ 1648 1647 SET_NETDEV_DEV(ndev, dev);
+2 -3
drivers/net/ethernet/ti/cpsw_new.c
··· 1420 1420 cpsw->quirk_irq ? 1421 1421 cpsw_rx_poll : cpsw_rx_mq_poll, 1422 1422 NAPI_POLL_WEIGHT); 1423 - netif_tx_napi_add(ndev, &cpsw->napi_tx, 1423 + netif_napi_add_tx(ndev, &cpsw->napi_tx, 1424 1424 cpsw->quirk_irq ? 1425 - cpsw_tx_poll : cpsw_tx_mq_poll, 1426 - NAPI_POLL_WEIGHT); 1425 + cpsw_tx_poll : cpsw_tx_mq_poll); 1427 1426 } 1428 1427 1429 1428 napi_ndev = ndev;
+1 -1
drivers/net/ethernet/ti/netcp_core.c
··· 2096 2096 2097 2097 /* NAPI register */ 2098 2098 netif_napi_add(ndev, &netcp->rx_napi, netcp_rx_poll, NAPI_POLL_WEIGHT); 2099 - netif_tx_napi_add(ndev, &netcp->tx_napi, netcp_tx_poll, NAPI_POLL_WEIGHT); 2099 + netif_napi_add_tx(ndev, &netcp->tx_napi, netcp_tx_poll); 2100 2100 2101 2101 /* Register the network device */ 2102 2102 ndev->dev_id = 0;
+2 -2
drivers/net/ipa/gsi.c
··· 1614 1614 gsi_channel_program(channel, true); 1615 1615 1616 1616 if (channel->toward_ipa) 1617 - netif_tx_napi_add(&gsi->dummy_dev, &channel->napi, 1618 - gsi_channel_poll, NAPI_POLL_WEIGHT); 1617 + netif_napi_add_tx(&gsi->dummy_dev, &channel->napi, 1618 + gsi_channel_poll); 1619 1619 else 1620 1620 netif_napi_add(&gsi->dummy_dev, &channel->napi, 1621 1621 gsi_channel_poll, NAPI_POLL_WEIGHT);
+1 -2
drivers/net/tun.c
··· 268 268 tfile->napi_enabled = napi_en; 269 269 tfile->napi_frags_enabled = napi_en && napi_frags; 270 270 if (napi_en) { 271 - netif_tx_napi_add(tun->dev, &tfile->napi, tun_napi_poll, 272 - NAPI_POLL_WEIGHT); 271 + netif_napi_add_tx(tun->dev, &tfile->napi, tun_napi_poll); 273 272 napi_enable(&tfile->napi); 274 273 } 275 274 }
+1 -2
drivers/s390/net/qeth_core_main.c
··· 7099 7099 7100 7100 local_bh_disable(); 7101 7101 qeth_for_each_output_queue(card, queue, i) { 7102 - netif_tx_napi_add(dev, &queue->napi, qeth_tx_poll, 7103 - NAPI_POLL_WEIGHT); 7102 + netif_napi_add_tx(dev, &queue->napi, qeth_tx_poll); 7104 7103 napi_enable(&queue->napi); 7105 7104 napi_schedule(&queue->napi); 7106 7105 }
+2 -2
net/mptcp/protocol.c
··· 3786 3786 for_each_possible_cpu(cpu) { 3787 3787 delegated = per_cpu_ptr(&mptcp_delegated_actions, cpu); 3788 3788 INIT_LIST_HEAD(&delegated->head); 3789 - netif_tx_napi_add(&mptcp_napi_dev, &delegated->napi, mptcp_napi_poll, 3790 - NAPI_POLL_WEIGHT); 3789 + netif_napi_add_tx(&mptcp_napi_dev, &delegated->napi, 3790 + mptcp_napi_poll); 3791 3791 napi_enable(&delegated->napi); 3792 3792 } 3793 3793