ethernet: use eth_hw_addr_set() - casts

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

eth_hw_addr_set() takes a u8 pointer, like other
etherdevice helpers. Convert the few drivers which
require casts because they memcpy from "endian marked"
types.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jakub Kicinski and committed by

David S. Miller 4 years ago 16be9a16 4d3d2c8d

+3 -3

3 changed files

expand all

drivers

net

ethernet

3com

3c509.c

cortina

gemini.c

intel

e100.c

+1 -1

drivers/net/ethernet/3com/3c509.c

··· 270 270 { 271 271 struct el3_private *lp = netdev_priv(dev); 272 272 273 - memcpy(dev->dev_addr, phys_addr, ETH_ALEN); 273 + eth_hw_addr_set(dev, (u8 *)phys_addr); 274 274 dev->base_addr = ioaddr; 275 275 dev->irq = irq; 276 276 dev->if_port = if_port;

+1 -1

drivers/net/ethernet/cortina/gemini.c

··· 2467 2467 DEFAULT_NAPI_WEIGHT); 2468 2468 2469 2469 if (is_valid_ether_addr((void *)port->mac_addr)) { 2470 - memcpy(netdev->dev_addr, port->mac_addr, ETH_ALEN); 2470 + eth_hw_addr_set(netdev, (u8 *)port->mac_addr); 2471 2471 } else { 2472 2472 dev_dbg(dev, "ethernet address 0x%08x%08x%08x invalid\n", 2473 2473 port->mac_addr[0], port->mac_addr[1],

+1 -1

drivers/net/ethernet/intel/e100.c

··· 2921 2921 2922 2922 e100_phy_init(nic); 2923 2923 2924 - memcpy(netdev->dev_addr, nic->eeprom, ETH_ALEN); 2924 + eth_hw_addr_set(netdev, (u8 *)nic->eeprom); 2925 2925 if (!is_valid_ether_addr(netdev->dev_addr)) { 2926 2926 if (!eeprom_bad_csum_allow) { 2927 2927 netif_err(nic, probe, nic->netdev, "Invalid MAC address from EEPROM, aborting\n");