Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

nvme: fix multiple spelling and grammar issues in host drivers

This commit fixes several typos and grammatical issues across various
nvme host driver files:

- correct "glace" to "glance" in a comment in apple.c
- fix "Idependent" to "Independent" in core.c
- change "unsucceesful" to "unsuccessful", "they blk-mq" to "the blk-mq",
- fix "terminaed" to "terminated" and other grammar in fc.c
- update "O's" to "0's" to clarify meaning in nvme.h
- fix a function name reference in a comment in zns.c:
*_transter_len() -> *_transfer_len().
- fix sysfs_emit() output format in pci.c (replace x%08x with 0x%08x)

These changes improve the code readability and documentation consistency
across the NVMe driver.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

authored by

Alok Tiwari and committed by
Christoph Hellwig
164c187d ab17ead0

+14 -14
+2 -2
drivers/nvme/host/apple.c
··· 301 301 memcpy(&q->sqes[tag], cmd, sizeof(*cmd)); 302 302 303 303 /* 304 - * This lock here doesn't make much sense at a first glace but 305 - * removing it will result in occasional missed completetion 304 + * This lock here doesn't make much sense at a first glance but 305 + * removing it will result in occasional missed completion 306 306 * interrupts even though the commands still appear on the CQ. 307 307 * It's unclear why this happens but our best guess is that 308 308 * there is a bug in the firmware triggered when a new command
+1 -1
drivers/nvme/host/core.c
··· 4286 4286 } 4287 4287 4288 4288 /* 4289 - * If available try to use the Command Set Idependent Identify Namespace 4289 + * If available try to use the Command Set Independent Identify Namespace 4290 4290 * data structure to find all the generic information that is needed to 4291 4291 * set up a namespace. If not fall back to the legacy version. 4292 4292 */
+5 -5
drivers/nvme/host/fc.c
··· 899 899 * may crash. 900 900 * 901 901 * As such: 902 - * Wrapper all the dma routines and check the dev pointer. 902 + * Wrap all the dma routines and check the dev pointer. 903 903 * 904 904 * If simple mappings (return just a dma address, we'll noop them, 905 905 * returning a dma address of 0. ··· 1955 1955 } 1956 1956 1957 1957 /* 1958 - * For the linux implementation, if we have an unsucceesful 1959 - * status, they blk-mq layer can typically be called with the 1958 + * For the linux implementation, if we have an unsuccessful 1959 + * status, the blk-mq layer can typically be called with the 1960 1960 * non-zero status and the content of the cqe isn't important. 1961 1961 */ 1962 1962 if (status) ··· 2429 2429 2430 2430 /* 2431 2431 * This routine runs through all outstanding commands on the association 2432 - * and aborts them. This routine is typically be called by the 2432 + * and aborts them. This routine is typically called by the 2433 2433 * delete_association routine. It is also called due to an error during 2434 2434 * reconnect. In that scenario, it is most likely a command that initializes 2435 2435 * the controller, including fabric Connect commands on io queues, that ··· 2622 2622 * as part of the exchange. The CQE is the last thing for the io, 2623 2623 * which is transferred (explicitly or implicitly) with the RSP IU 2624 2624 * sent on the exchange. After the CQE is received, the FC exchange is 2625 - * terminaed and the Exchange may be used on a different io. 2625 + * terminated and the Exchange may be used on a different io. 2626 2626 * 2627 2627 * The transport to LLDD api has the transport making a request for a 2628 2628 * new fcp io request to the LLDD. The LLDD then allocates a FC exchange
+1 -1
drivers/nvme/host/nvme.h
··· 69 69 NVME_QUIRK_IDENTIFY_CNS = (1 << 1), 70 70 71 71 /* 72 - * The controller deterministically returns O's on reads to 72 + * The controller deterministically returns 0's on reads to 73 73 * logical blocks that deallocate was called on. 74 74 */ 75 75 NVME_QUIRK_DEALLOCATE_ZEROES = (1 << 2),
+1 -1
drivers/nvme/host/pci.c
··· 2439 2439 { 2440 2440 struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev)); 2441 2441 2442 - return sysfs_emit(buf, "cmbloc : x%08x\ncmbsz : x%08x\n", 2442 + return sysfs_emit(buf, "cmbloc : 0x%08x\ncmbsz : 0x%08x\n", 2443 2443 ndev->cmbloc, ndev->cmbsz); 2444 2444 } 2445 2445 static DEVICE_ATTR_RO(cmb);
+1 -1
drivers/nvme/host/rdma.c
··· 877 877 878 878 /* 879 879 * Only start IO queues for which we have allocated the tagset 880 - * and limitted it to the available queues. On reconnects, the 880 + * and limited it to the available queues. On reconnects, the 881 881 * queue number might have changed. 882 882 */ 883 883 nr_queues = min(ctrl->tag_set.nr_hw_queues + 1, ctrl->ctrl.queue_count);
+2 -2
drivers/nvme/target/passthru.c
··· 106 106 pctrl->max_hw_sectors); 107 107 108 108 /* 109 - * nvmet_passthru_map_sg is limitted to using a single bio so limit 109 + * nvmet_passthru_map_sg is limited to using a single bio so limit 110 110 * the mdts based on BIO_MAX_VECS as well 111 111 */ 112 112 max_hw_sectors = min_not_zero(BIO_MAX_VECS << PAGE_SECTORS_SHIFT, ··· 147 147 * When passthru controller is setup using nvme-loop transport it will 148 148 * export the passthru ctrl subsysnqn (PCIe NVMe ctrl) and will fail in 149 149 * the nvme/host/core.c in the nvme_init_subsystem()->nvme_active_ctrl() 150 - * code path with duplicate ctr subsynqn. In order to prevent that we 150 + * code path with duplicate ctrl subsysnqn. In order to prevent that we 151 151 * mask the passthru-ctrl subsysnqn with the target ctrl subsysnqn. 152 152 */ 153 153 memcpy(id->subnqn, ctrl->subsysnqn, sizeof(id->subnqn));
+1 -1
drivers/nvme/target/zns.c
··· 541 541 struct bio *bio; 542 542 int sg_cnt; 543 543 544 - /* Request is completed on len mismatch in nvmet_check_transter_len() */ 544 + /* Request is completed on len mismatch in nvmet_check_transfer_len() */ 545 545 if (!nvmet_check_transfer_len(req, nvmet_rw_data_len(req))) 546 546 return; 547 547