Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Here, If devm_ioremap will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Arvind Yadav and committed by
David S. Miller
162809df 52f40e9d

+6
+6
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
··· 1469 1469 p->agl = (u64)devm_ioremap(&pdev->dev, p->agl_phys, p->agl_size); 1470 1470 p->agl_prt_ctl = (u64)devm_ioremap(&pdev->dev, p->agl_prt_ctl_phys, 1471 1471 p->agl_prt_ctl_size); 1472 + if (!p->mix || !p->agl || !p->agl_prt_ctl) { 1473 + dev_err(&pdev->dev, "failed to map I/O memory\n"); 1474 + result = -ENOMEM; 1475 + goto err; 1476 + } 1477 + 1472 1478 spin_lock_init(&p->lock); 1473 1479 1474 1480 skb_queue_head_init(&p->tx_list);