Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

energy_model: Use a fixed reference frequency

The last item of a performance domain is not always the performance point
that has been used to compute CPU's capacity. This can lead to different
target frequency compared with other part of the system like schedutil and
would result in wrong energy estimation.

A new arch_scale_freq_ref() is available to return a fixed and coherent
frequency reference that can be used when computing the CPU's frequency
for an level of utilization. Use this function to get this reference
frequency.

Energy model is never used without defining arch_scale_freq_ref() but
can be compiled. Define a default arch_scale_freq_ref() returning 0
in such case.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://lore.kernel.org/r/20231211104855.558096-5-vincent.guittot@linaro.org

authored by

Vincent Guittot and committed by
Ingo Molnar
15cbbd1d b3edde44

+3 -3
+3 -3
include/linux/energy_model.h
··· 224 224 unsigned long max_util, unsigned long sum_util, 225 225 unsigned long allowed_cpu_cap) 226 226 { 227 - unsigned long freq, scale_cpu; 227 + unsigned long freq, ref_freq, scale_cpu; 228 228 struct em_perf_state *ps; 229 229 int cpu; 230 230 ··· 241 241 */ 242 242 cpu = cpumask_first(to_cpumask(pd->cpus)); 243 243 scale_cpu = arch_scale_cpu_capacity(cpu); 244 - ps = &pd->table[pd->nr_perf_states - 1]; 244 + ref_freq = arch_scale_freq_ref(cpu); 245 245 246 246 max_util = min(max_util, allowed_cpu_cap); 247 - freq = map_util_freq(max_util, ps->frequency, scale_cpu); 247 + freq = map_util_freq(max_util, ref_freq, scale_cpu); 248 248 249 249 /* 250 250 * Find the lowest performance state of the Energy Model above the