Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: Add missing KERN_* constants to printks

According to kerneljanitors todo list all printk calls (beginning
a new line) should have an according KERN_* constant.
Those are the missing pieces here for the i2c subsystem.

Signed-off-by: Frank Seidel <frank@f-seidel.de>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

authored by

Frank Seidel and committed by
Jean Delvare
154d22b0 94d78e18

+11 -8
+1 -1
drivers/i2c/algos/i2c-algo-pcf.c
··· 61 61 62 62 static void i2c_start(struct i2c_algo_pcf_data *adap) 63 63 { 64 - DEBPROTO(printk("S ")); 64 + DEBPROTO(printk(KERN_DEBUG "S ")); 65 65 set_pcf(adap, 1, I2C_PCF_START); 66 66 } 67 67
+3 -2
drivers/i2c/busses/i2c-pca-isa.c
··· 49 49 { 50 50 #ifdef DEBUG_IO 51 51 static char *names[] = { "T/O", "DAT", "ADR", "CON" }; 52 - printk("*** write %s at %#lx <= %#04x\n", names[reg], base+reg, val); 52 + printk(KERN_DEBUG "*** write %s at %#lx <= %#04x\n", names[reg], 53 + base+reg, val); 53 54 #endif 54 55 outb(val, base+reg); 55 56 } ··· 61 60 #ifdef DEBUG_IO 62 61 { 63 62 static char *names[] = { "STA", "DAT", "ADR", "CON" }; 64 - printk("*** read %s => %#04x\n", names[reg], res); 63 + printk(KERN_DEBUG "*** read %s => %#04x\n", names[reg], res); 65 64 } 66 65 #endif 67 66 return res;
+2 -1
drivers/i2c/busses/i2c-powermac.c
··· 191 191 i2c_set_adapdata(adapter, NULL); 192 192 /* We aren't that prepared to deal with this... */ 193 193 if (rc) 194 - printk("i2c-powermac.c: Failed to remove bus %s !\n", 194 + printk(KERN_WARNING 195 + "i2c-powermac.c: Failed to remove bus %s !\n", 195 196 adapter->name); 196 197 platform_set_drvdata(dev, NULL); 197 198 kfree(adapter);
+5 -4
drivers/i2c/busses/i2c-pxa.c
··· 210 210 static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why) 211 211 { 212 212 unsigned int i; 213 - printk("i2c: error: %s\n", why); 214 - printk("i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n", 213 + printk(KERN_ERR "i2c: error: %s\n", why); 214 + printk(KERN_ERR "i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n", 215 215 i2c->msg_num, i2c->msg_idx, i2c->msg_ptr); 216 - printk("i2c: ICR: %08x ISR: %08x\n" 217 - "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c))); 216 + printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n", 217 + readl(_ICR(i2c)), readl(_ISR(i2c))); 218 + printk(KERN_DEBUG "i2c: log: "); 218 219 for (i = 0; i < i2c->irqlogidx; i++) 219 220 printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]); 220 221 printk("\n");