libata-core: auditting chk_status v check_status

Did a complete audit of these and found we have another error case.

ata_bus_softreset calls ata_check_status which means that it tries to do
an ioread8 on the port blindly and check versus 0xFF for an error.

It should of course be using the ap->ops method for this via chk_status,
and this bug causes a wrog status call on the NS87415 at least.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

authored by Alan Cox and committed by Jeff Garzik 150981b0 2dcb407e

+1 -1
+1 -1
drivers/ata/libata-core.c
··· 3267 3267 * the bus shows 0xFF because the odd clown forgets the D7 3268 3268 * pulldown resistor. 3269 3269 */ 3270 - if (ata_check_status(ap) == 0xFF) 3270 + if (ata_chk_status(ap) == 0xFF) 3271 3271 return -ENODEV; 3272 3272 3273 3273 return ata_bus_post_reset(ap, devmask, deadline);