Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fs/hpfs: use pr_fmt for logging

Also remove redundant level names (warning:...)

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Fabian Frederick and committed by
Linus Torvalds
14da17f9 b7cb1ce2

+56 -51
+6 -6
fs/hpfs/buffer.c
··· 55 55 if (bh != NULL) 56 56 return bh->b_data; 57 57 else { 58 - pr_warn("HPFS: hpfs_map_sector: read error\n"); 58 + pr_warn("hpfs_map_sector: read error\n"); 59 59 return NULL; 60 60 } 61 61 } ··· 76 76 set_buffer_uptodate(bh); 77 77 return bh->b_data; 78 78 } else { 79 - pr_warn("HPFS: hpfs_get_sector: getblk failed\n"); 79 + pr_warn("hpfs_get_sector: getblk failed\n"); 80 80 return NULL; 81 81 } 82 82 } ··· 93 93 cond_resched(); 94 94 95 95 if (secno & 3) { 96 - pr_warn("HPFS: hpfs_map_4sectors: unaligned read\n"); 96 + pr_warn("hpfs_map_4sectors: unaligned read\n"); 97 97 return NULL; 98 98 } 99 99 ··· 112 112 113 113 qbh->data = data = kmalloc(2048, GFP_NOFS); 114 114 if (!data) { 115 - pr_warn("HPFS: hpfs_map_4sectors: out of memory\n"); 115 + pr_warn("hpfs_map_4sectors: out of memory\n"); 116 116 goto bail4; 117 117 } 118 118 ··· 145 145 hpfs_lock_assert(s); 146 146 147 147 if (secno & 3) { 148 - pr_warn("HPFS: hpfs_get_4sectors: unaligned read\n"); 148 + pr_warn("hpfs_get_4sectors: unaligned read\n"); 149 149 return NULL; 150 150 } 151 151 ··· 161 161 } 162 162 163 163 if (!(qbh->data = kmalloc(2048, GFP_NOFS))) { 164 - pr_warn("HPFS: hpfs_get_4sectors: out of memory\n"); 164 + pr_warn("hpfs_get_4sectors: out of memory\n"); 165 165 goto bail4; 166 166 } 167 167 return qbh->data;
+1 -1
fs/hpfs/dir.c
··· 127 127 if (ctx->pos == 12) 128 128 goto out; 129 129 if (ctx->pos == 3 || ctx->pos == 4 || ctx->pos == 5) { 130 - pr_warn("HPFS: warning: pos==%d\n", (int)ctx->pos); 130 + pr_warn("pos==%d\n", (int)ctx->pos); 131 131 goto out; 132 132 } 133 133 if (ctx->pos == 0) {
+14 -14
fs/hpfs/dnode.c
··· 17 17 if (de == fde) return ((loff_t) le32_to_cpu(d->self) << 4) | (loff_t)i; 18 18 i++; 19 19 } 20 - pr_info("HPFS: get_pos: not_found\n"); 20 + pr_info("get_pos: not_found\n"); 21 21 return ((loff_t)le32_to_cpu(d->self) << 4) | (loff_t)1; 22 22 } 23 23 ··· 32 32 if (hpfs_inode->i_rddir_off[i] == pos) return; 33 33 if (!(i&0x0f)) { 34 34 if (!(ppos = kmalloc((i+0x11) * sizeof(loff_t*), GFP_NOFS))) { 35 - pr_warn("HPFS: out of memory for position list\n"); 35 + pr_warn("out of memory for position list\n"); 36 36 return; 37 37 } 38 38 if (hpfs_inode->i_rddir_off) { ··· 63 63 } 64 64 return; 65 65 not_f: 66 - /*pr_info("HPFS: warning: position pointer %p->%08x not found\n", 66 + /*pr_warn("position pointer %p->%08x not found\n", 67 67 pos, (int)*pos);*/ 68 68 return; 69 69 } ··· 94 94 if ((*p & ~0x3f) == (d & ~0x3f) && (*p & 0x3f) >= (d & 0x3f)) { 95 95 int n = (*p & 0x3f) + c; 96 96 if (n > 0x3f) 97 - pr_warn("HPFS: hpfs_pos_ins: %08x + %d\n", 97 + pr_warn("hpfs_pos_ins: %08x + %d\n", 98 98 (int)*p, (int)c >> 8); 99 99 else 100 100 *p = (*p & ~0x3f) | n; ··· 106 106 if ((*p & ~0x3f) == (d & ~0x3f) && (*p & 0x3f) >= (d & 0x3f)) { 107 107 int n = (*p & 0x3f) - c; 108 108 if (n < 1) 109 - pr_warn("HPFS: hpfs_pos_ins: %08x - %d\n", 109 + pr_warn("hpfs_pos_ins: %08x - %d\n", 110 110 (int)*p, (int)c >> 8); 111 111 else 112 112 *p = (*p & ~0x3f) | n; ··· 246 246 struct fnode *fnode; 247 247 int c1, c2 = 0; 248 248 if (!(nname = kmalloc(256, GFP_NOFS))) { 249 - pr_warn("HPFS: out of memory, can't add to dnode\n"); 249 + pr_warn("out of memory, can't add to dnode\n"); 250 250 return 1; 251 251 } 252 252 go_up: ··· 288 288 not be any error while splitting dnodes, otherwise the 289 289 whole directory, not only file we're adding, would 290 290 be lost. */ 291 - pr_warn("HPFS: out of memory for dnode splitting\n"); 291 + pr_warn("out of memory for dnode splitting\n"); 292 292 hpfs_brelse4(&qbh); 293 293 kfree(nname); 294 294 return 1; ··· 604 604 if (!de_next->down) goto endm; 605 605 ndown = de_down_pointer(de_next); 606 606 if (!(de_cp = kmalloc(le16_to_cpu(de->length), GFP_NOFS))) { 607 - pr_warn("HPFS: out of memory for dtree balancing\n"); 607 + pr_warn("out of memory for dtree balancing\n"); 608 608 goto endm; 609 609 } 610 610 memcpy(de_cp, de, le16_to_cpu(de->length)); ··· 645 645 if (!dlp && down) { 646 646 if (le32_to_cpu(d1->first_free) > 2044) { 647 647 if (hpfs_sb(i->i_sb)->sb_chk >= 2) { 648 - pr_warn("HPFS: warning: unbalanced dnode tree, see hpfs.txt 4 more info\n"); 649 - pr_warn("HPFS: warning: terminating balancing operation\n"); 648 + pr_warn("unbalanced dnode tree, see hpfs.txt 4 more info\n"); 649 + pr_warn("terminating balancing operation\n"); 650 650 } 651 651 hpfs_brelse4(&qbh1); 652 652 goto endm; 653 653 } 654 654 if (hpfs_sb(i->i_sb)->sb_chk >= 2) { 655 - pr_warn("HPFS: warning: unbalanced dnode tree, see hpfs.txt 4 more info\n"); 656 - pr_warn("HPFS: warning: goin'on\n"); 655 + pr_warn("unbalanced dnode tree, see hpfs.txt 4 more info\n"); 656 + pr_warn("goin'on\n"); 657 657 } 658 658 le16_add_cpu(&del->length, 4); 659 659 del->down = 1; ··· 667 667 *(__le32 *) ((void *) del + le16_to_cpu(del->length) - 4) = cpu_to_le32(down); 668 668 } else goto endm; 669 669 if (!(de_cp = kmalloc(le16_to_cpu(de_prev->length), GFP_NOFS))) { 670 - pr_warn("HPFS: out of memory for dtree balancing\n"); 670 + pr_warn("out of memory for dtree balancing\n"); 671 671 hpfs_brelse4(&qbh1); 672 672 goto endm; 673 673 } ··· 1008 1008 int d1, d2 = 0; 1009 1009 name1 = f->name; 1010 1010 if (!(name2 = kmalloc(256, GFP_NOFS))) { 1011 - pr_warn("HPFS: out of memory, can't map dirent\n"); 1011 + pr_warn("out of memory, can't map dirent\n"); 1012 1012 return NULL; 1013 1013 } 1014 1014 if (f->len <= 15)
+3 -3
fs/hpfs/ea.c
··· 51 51 { 52 52 char *ret; 53 53 if (!(ret = kmalloc(size + 1, GFP_NOFS))) { 54 - pr_warn("HPFS: out of memory for EA\n"); 54 + pr_warn("out of memory for EA\n"); 55 55 return NULL; 56 56 } 57 57 if (hpfs_ea_read(s, a, ano, 0, size, ret)) { ··· 139 139 if (ea_indirect(ea)) 140 140 return get_indirect_ea(s, ea_in_anode(ea), ea_sec(ea), *size = ea_len(ea)); 141 141 if (!(ret = kmalloc((*size = ea_valuelen(ea)) + 1, GFP_NOFS))) { 142 - pr_warn("HPFS: out of memory for EA\n"); 142 + pr_warn("out of memory for EA\n"); 143 143 return NULL; 144 144 } 145 145 memcpy(ret, ea_data(ea), ea_valuelen(ea)); ··· 165 165 if (ea_indirect(ea)) 166 166 return get_indirect_ea(s, ea_in_anode(ea), ea_sec(ea), *size = ea_len(ea)); 167 167 if (!(ret = kmalloc((*size = ea_valuelen(ea)) + 1, GFP_NOFS))) { 168 - pr_warn("HPFS: out of memory for EA\n"); 168 + pr_warn("out of memory for EA\n"); 169 169 return NULL; 170 170 } 171 171 if (hpfs_ea_read(s, a, ano, pos + 4 + ea->namelen + 1, ea_valuelen(ea), ret)) {
+5
fs/hpfs/hpfs_fn.h
··· 8 8 9 9 //#define DBG 10 10 //#define DEBUG_LOCKS 11 + #ifdef pr_fmt 12 + #undef pr_fmt 13 + #endif 14 + 15 + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 11 16 12 17 #include <linux/mutex.h> 13 18 #include <linux/pagemap.h>
+1 -1
fs/hpfs/inode.c
··· 184 184 if (i->i_ino == hpfs_sb(i->i_sb)->sb_root) return; 185 185 if (hpfs_inode->i_rddir_off && !atomic_read(&i->i_count)) { 186 186 if (*hpfs_inode->i_rddir_off) 187 - pr_warn("HPFS: write_inode: some position still there\n"); 187 + pr_warn("write_inode: some position still there\n"); 188 188 kfree(hpfs_inode->i_rddir_off); 189 189 hpfs_inode->i_rddir_off = NULL; 190 190 }
+7 -7
fs/hpfs/map.c
··· 65 65 struct code_page_directory *cp = hpfs_map_sector(s, cps, &bh, 0); 66 66 if (!cp) return NULL; 67 67 if (le32_to_cpu(cp->magic) != CP_DIR_MAGIC) { 68 - pr_warn("HPFS: Code page directory magic doesn't match (magic = %08x)\n", 68 + pr_warn("Code page directory magic doesn't match (magic = %08x)\n", 69 69 le32_to_cpu(cp->magic)); 70 70 brelse(bh); 71 71 return NULL; 72 72 } 73 73 if (!le32_to_cpu(cp->n_code_pages)) { 74 - pr_warn("HPFS: n_code_pages == 0\n"); 74 + pr_warn("n_code_pages == 0\n"); 75 75 brelse(bh); 76 76 return NULL; 77 77 } ··· 80 80 brelse(bh); 81 81 82 82 if (cpi >= 3) { 83 - pr_warn("HPFS: Code page index out of array\n"); 83 + pr_warn("Code page index out of array\n"); 84 84 return NULL; 85 85 } 86 86 87 87 if (!(cpd = hpfs_map_sector(s, cpds, &bh, 0))) return NULL; 88 88 if (le16_to_cpu(cpd->offs[cpi]) > 0x178) { 89 - pr_warn("HPFS: Code page index out of sector\n"); 89 + pr_warn("Code page index out of sector\n"); 90 90 brelse(bh); 91 91 return NULL; 92 92 } 93 93 ptr = (unsigned char *)cpd + le16_to_cpu(cpd->offs[cpi]) + 6; 94 94 if (!(cp_table = kmalloc(256, GFP_KERNEL))) { 95 - pr_warn("HPFS: out of memory for code page table\n"); 95 + pr_warn("out of memory for code page table\n"); 96 96 brelse(bh); 97 97 return NULL; 98 98 } ··· 115 115 int i; 116 116 __le32 *b; 117 117 if (!(b = kmalloc(n * 512, GFP_KERNEL))) { 118 - pr_warn("HPFS: can't allocate memory for bitmap directory\n"); 118 + pr_warn("can't allocate memory for bitmap directory\n"); 119 119 return NULL; 120 120 } 121 121 for (i=0;i<n;i++) { ··· 283 283 goto bail; 284 284 } 285 285 if (b == 3) 286 - pr_warn("HPFS: warning: unbalanced dnode tree, dnode %08x; see hpfs.txt 4 more info\n", 286 + pr_warn("unbalanced dnode tree, dnode %08x; see hpfs.txt 4 more info\n", 287 287 secno); 288 288 } 289 289 return dnode;
+3 -3
fs/hpfs/name.c
··· 56 56 unsigned char *to; 57 57 int i; 58 58 if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { 59 - pr_warn("HPFS: Long name flag mismatch - name "); 59 + pr_warn("Long name flag mismatch - name "); 60 60 for (i = 0; i < len; i++) 61 61 pr_cont("%c", from[i]); 62 62 pr_cont(" misidentified as %s.\n", lng ? "short" : "long"); 63 - pr_warn("HPFS: It's nothing serious. It could happen because of bug in OS/2.\nHPFS: Set checks=normal to disable this message.\n"); 63 + pr_warn("It's nothing serious. It could happen because of bug in OS/2.\nSet checks=normal to disable this message.\n"); 64 64 } 65 65 if (!lc) return from; 66 66 if (!(to = kmalloc(len, GFP_KERNEL))) { 67 - pr_warn("HPFS: can't allocate memory for name conversion buffer\n"); 67 + pr_warn("can't allocate memory for name conversion buffer\n"); 68 68 return from; 69 69 } 70 70 for (i = 0; i < len; i++) to[i] = locase(hpfs_sb(s)->sb_cp_table,from[i]);
+1 -1
fs/hpfs/namei.c
··· 404 404 d_rehash(dentry); 405 405 } else { 406 406 struct iattr newattrs; 407 - /*pr_info("HPFS: truncating file before delete.\n");*/ 407 + /*pr_info("truncating file before delete.\n");*/ 408 408 newattrs.ia_size = 0; 409 409 newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; 410 410 err = notify_change(dentry, &newattrs, NULL);
+15 -15
fs/hpfs/super.c
··· 62 62 vsnprintf(err_buf, sizeof(err_buf), fmt, args); 63 63 va_end(args); 64 64 65 - pr_err("HPFS: filesystem error: %s", err_buf); 65 + pr_err("filesystem error: %s", err_buf); 66 66 if (!hpfs_sb(s)->sb_was_error) { 67 67 if (hpfs_sb(s)->sb_err == 2) { 68 68 pr_cont("; crashing the system because you wanted it\n"); ··· 438 438 439 439 if (!(o = parse_opts(data, &uid, &gid, &umask, &lowercase, 440 440 &eas, &chk, &errs, &chkdsk, &timeshift))) { 441 - pr_warn("HPFS: bad mount options.\n"); 441 + pr_warn("bad mount options.\n"); 442 442 goto out_err; 443 443 } 444 444 if (o == 2) { ··· 446 446 goto out_err; 447 447 } 448 448 if (timeshift != sbi->sb_timeshift) { 449 - pr_warn("HPFS: timeshift can't be changed using remount.\n"); 449 + pr_warn("timeshift can't be changed using remount.\n"); 450 450 goto out_err; 451 451 } 452 452 ··· 527 527 528 528 if (!(o = parse_opts(options, &uid, &gid, &umask, &lowercase, 529 529 &eas, &chk, &errs, &chkdsk, &timeshift))) { 530 - pr_warn("HPFS: bad mount options.\n"); 530 + pr_warn("bad mount options.\n"); 531 531 goto bail0; 532 532 } 533 533 if (o==2) { ··· 547 547 ||*/ le32_to_cpu(superblock->magic) != SB_MAGIC 548 548 || le32_to_cpu(spareblock->magic) != SP_MAGIC) { 549 549 if (!silent) 550 - pr_warn("HPFS: Bad magic ... probably not HPFS\n"); 550 + pr_warn("Bad magic ... probably not HPFS\n"); 551 551 goto bail4; 552 552 } 553 553 554 554 /* Check version */ 555 555 if (!(s->s_flags & MS_RDONLY) && 556 556 superblock->funcversion != 2 && superblock->funcversion != 3) { 557 - pr_warn("HPFS: Bad version %d,%d. Mount readonly to go around\n", 557 + pr_warn("Bad version %d,%d. Mount readonly to go around\n", 558 558 (int)superblock->version, (int)superblock->funcversion); 559 - pr_warn("HPFS: please try recent version of HPFS driver at http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/index-e.cgi and if it still can't understand this format, contact author - mikulas@artax.karlin.mff.cuni.cz\n"); 559 + pr_warn("please try recent version of HPFS driver at http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/index-e.cgi and if it still can't understand this format, contact author - mikulas@artax.karlin.mff.cuni.cz\n"); 560 560 goto bail4; 561 561 } 562 562 ··· 602 602 /* Check for general fs errors*/ 603 603 if (spareblock->dirty && !spareblock->old_wrote) { 604 604 if (errs == 2) { 605 - pr_warn("HPFS: Improperly stopped, not mounted\n"); 605 + pr_warn("Improperly stopped, not mounted\n"); 606 606 goto bail4; 607 607 } 608 608 hpfs_error(s, "improperly stopped"); ··· 616 616 617 617 if (spareblock->hotfixes_used || spareblock->n_spares_used) { 618 618 if (errs >= 2) { 619 - pr_warn("HPFS: Hotfixes not supported here, try chkdsk\n"); 619 + pr_warn("Hotfixes not supported here, try chkdsk\n"); 620 620 mark_dirty(s, 0); 621 621 goto bail4; 622 622 } 623 623 hpfs_error(s, "hotfixes not supported here, try chkdsk"); 624 624 if (errs == 0) 625 - pr_warn("HPFS: Proceeding, but your filesystem will be probably corrupted by this driver...\n"); 625 + pr_warn("Proceeding, but your filesystem will be probably corrupted by this driver...\n"); 626 626 else 627 - pr_warn("HPFS: This driver may read bad files or crash when operating on disk with hotfixes.\n"); 627 + pr_warn("This driver may read bad files or crash when operating on disk with hotfixes.\n"); 628 628 } 629 629 if (le32_to_cpu(spareblock->n_dnode_spares) != le32_to_cpu(spareblock->n_dnode_spares_free)) { 630 630 if (errs >= 2) { 631 - pr_warn("HPFS: Spare dnodes used, try chkdsk\n"); 631 + pr_warn("Spare dnodes used, try chkdsk\n"); 632 632 mark_dirty(s, 0); 633 633 goto bail4; 634 634 } 635 635 hpfs_error(s, "warning: spare dnodes used, try chkdsk"); 636 636 if (errs == 0) 637 - pr_warn("HPFS: Proceeding, but your filesystem could be corrupted if you delete files or directories\n"); 637 + pr_warn("Proceeding, but your filesystem could be corrupted if you delete files or directories\n"); 638 638 } 639 639 if (chk) { 640 640 unsigned a; ··· 654 654 } 655 655 sbi->sb_dirband_size = a; 656 656 } else 657 - pr_warn("HPFS: You really don't want any checks? You are crazy...\n"); 657 + pr_warn("You really don't want any checks? You are crazy...\n"); 658 658 659 659 /* Load code page table */ 660 660 if (le32_to_cpu(spareblock->n_code_pages)) 661 661 if (!(sbi->sb_cp_table = hpfs_load_code_page(s, le32_to_cpu(spareblock->code_page_dir)))) 662 - pr_warn("HPFS: Warning: code page support is disabled\n"); 662 + pr_warn("code page support is disabled\n"); 663 663 664 664 brelse(bh2); 665 665 brelse(bh1);