Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: fnic: Use vzalloc()

Use vzalloc() instead of hand writing it with vmalloc()+memset(). This is
less verbose.

This also fixes some style issues :)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/a1179941a6d440140513e681f4f3a1b92c8d83ae.1685210773.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Christophe JAILLET and committed by
Martin K. Petersen
14ce2c26 4851c39a

+2 -6
+2 -6
drivers/scsi/fnic/fnic_debugfs.c
··· 201 201 return -ENOMEM; 202 202 203 203 if (*rdata_ptr == fc_trc_flag->fnic_trace) { 204 - fnic_dbg_prt->buffer = vmalloc(array3_size(3, trace_max_pages, 204 + fnic_dbg_prt->buffer = vzalloc(array3_size(3, trace_max_pages, 205 205 PAGE_SIZE)); 206 206 if (!fnic_dbg_prt->buffer) { 207 207 kfree(fnic_dbg_prt); 208 208 return -ENOMEM; 209 209 } 210 - memset((void *)fnic_dbg_prt->buffer, 0, 211 - 3 * (trace_max_pages * PAGE_SIZE)); 212 210 fnic_dbg_prt->buffer_len = fnic_get_trace_data(fnic_dbg_prt); 213 211 } else { 214 212 fnic_dbg_prt->buffer = 215 - vmalloc(array3_size(3, fnic_fc_trace_max_pages, 213 + vzalloc(array3_size(3, fnic_fc_trace_max_pages, 216 214 PAGE_SIZE)); 217 215 if (!fnic_dbg_prt->buffer) { 218 216 kfree(fnic_dbg_prt); 219 217 return -ENOMEM; 220 218 } 221 - memset((void *)fnic_dbg_prt->buffer, 0, 222 - 3 * (fnic_fc_trace_max_pages * PAGE_SIZE)); 223 219 fnic_dbg_prt->buffer_len = 224 220 fnic_fc_trace_get_data(fnic_dbg_prt, *rdata_ptr); 225 221 }