Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: sun3x_esp: Add IRQ check

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding the real
error code. Stop calling request_irq() with the invalid IRQ #s.

Link: https://lore.kernel.org/r/363eb4c8-a3bf-4dc9-2a9e-90f349030a15@omprussia.ru
Fixes: 0bb67f181834 ("[SCSI] sun3x_esp: convert to esp_scsi")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Sergey Shtylyov and committed by
Martin K. Petersen
14b32138 38fca15c

+3 -1
+3 -1
drivers/scsi/sun3x_esp.c
··· 206 206 if (!esp->command_block) 207 207 goto fail_unmap_regs_dma; 208 208 209 - host->irq = platform_get_irq(dev, 0); 209 + host->irq = err = platform_get_irq(dev, 0); 210 + if (err < 0) 211 + goto fail_unmap_command_block; 210 212 err = request_irq(host->irq, scsi_esp_intr, IRQF_SHARED, 211 213 "SUN3X ESP", esp); 212 214 if (err < 0)