Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kconfig: fix make oldconfig

Linus wrote:
This seems to make "make oldconfig" a _lot_ more verbose than it
used to be. In a very annoying way.

I just did a quick git bisect. It's introduced by commit 4062f1a4c030
("kconfig: use long options in conf") by Sam Ravnborg. Apparently that
thing is totally buggy, and doesn't just change the option names, but
actively breaks them.

The old behaviour (from years ago) were reintroduced by accident. Fix
this so we are back to the version that are silent if there is nothing
to ask about.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Michal Marek <mmarek@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Sam Ravnborg and committed by
Linus Torvalds
14828349 31d1d48e

+1 -1
+1 -1
scripts/kconfig/conf.c
··· 599 599 break; 600 600 case savedefconfig: 601 601 break; 602 - case oldconfig: 603 602 case oldaskconfig: 604 603 rootEntry = &rootmenu; 605 604 conf(&rootmenu); 606 605 input_mode = silentoldconfig; 607 606 /* fall through */ 607 + case oldconfig: 608 608 case listnewconfig: 609 609 case oldnoconfig: 610 610 case silentoldconfig: