[PATCH] uml: pte_mkread fix

Fix the fact that pte_mkread set _PAGE_RW instead of _PAGE_USER (the logic is
copied from i386 in most place, so it is really as bad as you're thinking).

Thus currently page tables are more permissive than they should.

Such a change may trigger other latent bugs, so be careful with this.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jeff Dike and committed by
Linus Torvalds
1463fdbc 14251809

+1 -1
+1 -1
include/asm-um/pgtable.h
··· 270 270 271 271 static inline pte_t pte_mkread(pte_t pte) 272 272 { 273 - pte_set_bits(pte, _PAGE_RW); 273 + pte_set_bits(pte, _PAGE_USER); 274 274 return(pte_mknewprot(pte)); 275 275 } 276 276