Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc: Update comments in irqflags.h

The comment on TRACE_ENABLE_INTS is incorrect, and appears to have
always been incorrect since the code was merged. It probably came from
an original out-of-tree patch.

Replace it with something that's correct. Also propagate the message to
RECONCILE_IRQ_STATE(), because it's potentially subtle.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

authored by

Michael Ellerman and committed by
Benjamin Herrenschmidt
144beb2f 4e2bf01b

+5 -3
+5 -3
arch/powerpc/include/asm/irqflags.h
··· 32 32 #endif 33 33 34 34 /* 35 - * Most of the CPU's IRQ-state tracing is done from assembly code; we 36 - * have to call a C function so call a wrapper that saves all the 37 - * C-clobbered registers. 35 + * These are calls to C code, so the caller must be prepared for volatiles to 36 + * be clobbered. 38 37 */ 39 38 #define TRACE_ENABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_on) 40 39 #define TRACE_DISABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_off) ··· 41 42 /* 42 43 * This is used by assembly code to soft-disable interrupts first and 43 44 * reconcile irq state. 45 + * 46 + * NB: This may call C code, so the caller must be prepared for volatiles to 47 + * be clobbered. 44 48 */ 45 49 #define RECONCILE_IRQ_STATE(__rA, __rB) \ 46 50 lbz __rA,PACASOFTIRQEN(r13); \