Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rhashtable: fix for resize events during table walk

If rhashtable_walk_next detects a resize operation in progress, it jumps
to the new table and continues walking that one. But it misses to drop
the reference to it's current item, leading it to continue traversing
the new table's bucket in which the current item is sorted into, and
after reaching that bucket's end continues traversing the new table's
second bucket instead of the first one, thereby potentially missing
items.

This fixes the rhashtable runtime test for me. Bug probably introduced
by Herbert Xu's patch eddee5ba ("rhashtable: Fix walker behaviour during
rehash") although not explicitly tested.

Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Phil Sutter and committed by
David S. Miller
142b942a f7e2965d

+2 -2
+2 -2
lib/rhashtable.c
··· 610 610 iter->skip = 0; 611 611 } 612 612 613 + iter->p = NULL; 614 + 613 615 /* Ensure we see any new tables. */ 614 616 smp_rmb(); 615 617 ··· 621 619 iter->skip = 0; 622 620 return ERR_PTR(-EAGAIN); 623 621 } 624 - 625 - iter->p = NULL; 626 622 627 623 return NULL; 628 624 }