Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: 88pm800: Fix I2C device resource leak if probe fails

During probe the driver allocates two dummy I2C devices for subchips in
function pm800_pages_init(). Additionally this function allocates
regmaps for these subchips. If any of these steps fail then these dummy
I2C devices are not freed and resources leak.

On pm800_pages_init() fail the driver must call pm800_pages_exit() to
unregister dummy I2C devices.

Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

authored by

Krzysztof Kozlowski and committed by
Lee Jones
141050cf 921a1b0c

+1 -2
+1 -2
drivers/mfd/88pm800.c
··· 571 571 ret = pm800_pages_init(chip); 572 572 if (ret) { 573 573 dev_err(&client->dev, "pm800_pages_init failed!\n"); 574 - goto err_page_init; 574 + goto err_device_init; 575 575 } 576 576 577 577 ret = device_800_init(chip, pdata); ··· 587 587 588 588 err_device_init: 589 589 pm800_pages_exit(chip); 590 - err_page_init: 591 590 err_subchip_alloc: 592 591 pm80x_deinit(); 593 592 out_init: