Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thermal/drivers/mediatek/lvts_thermal: Fix sensor 1 interrupt status bitmask

The binary representation for sensor 1 interrupt status was incorrectly
assembled, when compared to the full table given in the same comment
section. The conversion into hex was also incorrect, leading to
incorrect interrupt status bitmask for sensor 1. This would cause the
driver to incorrectly identify changes for sensor 1, when in fact it
was sensor 0, or a sensor access time out.

Fix the binary and hex representations in the comments, and the actual
bitmask macro.

Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230328031017.1360976-1-wenst@chromium.org

authored by

Chen-Yu Tsai and committed by
Daniel Lezcano
13f03bcd 45cc9c4f

+3 -3
+3 -3
drivers/thermal/mediatek/lvts_thermal.c
··· 66 66 #define LVTS_MONINT_CONF 0x9FBF7BDE 67 67 68 68 #define LVTS_INT_SENSOR0 0x0009001F 69 - #define LVTS_INT_SENSOR1 0X000881F0 69 + #define LVTS_INT_SENSOR1 0x001203E0 70 70 #define LVTS_INT_SENSOR2 0x00247C00 71 71 #define LVTS_INT_SENSOR3 0x1FC00000 72 72 ··· 395 395 * => 0x1FC00000 396 396 * sensor 2 interrupt: 0000 0000 0010 0100 0111 1100 0000 0000 397 397 * => 0x00247C00 398 - * sensor 1 interrupt: 0000 0000 0001 0001 0000 0011 1110 0000 399 - * => 0X000881F0 398 + * sensor 1 interrupt: 0000 0000 0001 0010 0000 0011 1110 0000 399 + * => 0X001203E0 400 400 * sensor 0 interrupt: 0000 0000 0000 1001 0000 0000 0001 1111 401 401 * => 0x0009001F 402 402 */