Merge branch 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull CPU hotplug fix from Thomas Gleixner:
"Remove the stale skip_onerr member from the hotplug states"

* 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
cpu/hotplug: Remove skip_onerr field from cpuhp_step structure

+4 -22
+4 -22
kernel/cpu.c
··· 102 102 * @name: Name of the step 103 103 * @startup: Startup function of the step 104 104 * @teardown: Teardown function of the step 105 - * @skip_onerr: Do not invoke the functions on error rollback 106 - * Will go away once the notifiers are gone 107 105 * @cant_stop: Bringup/teardown can't be stopped at this step 108 106 */ 109 107 struct cpuhp_step { ··· 117 119 struct hlist_node *node); 118 120 } teardown; 119 121 struct hlist_head list; 120 - bool skip_onerr; 121 122 bool cant_stop; 122 123 bool multi_instance; 123 124 }; ··· 547 550 548 551 static void undo_cpu_up(unsigned int cpu, struct cpuhp_cpu_state *st) 549 552 { 550 - for (st->state--; st->state > st->target; st->state--) { 551 - struct cpuhp_step *step = cpuhp_get_step(st->state); 552 - 553 - if (!step->skip_onerr) 554 - cpuhp_invoke_callback(cpu, st->state, false, NULL, NULL); 555 - } 553 + for (st->state--; st->state > st->target; st->state--) 554 + cpuhp_invoke_callback(cpu, st->state, false, NULL, NULL); 556 555 } 557 556 558 557 static int cpuhp_up_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st, ··· 637 644 638 645 WARN_ON_ONCE(!cpuhp_is_ap_state(state)); 639 646 640 - if (st->rollback) { 641 - struct cpuhp_step *step = cpuhp_get_step(state); 642 - if (step->skip_onerr) 643 - goto next; 644 - } 645 - 646 647 if (cpuhp_is_atomic_state(state)) { 647 648 local_irq_disable(); 648 649 st->result = cpuhp_invoke_callback(cpu, state, bringup, st->node, &st->last); ··· 660 673 st->should_run = false; 661 674 } 662 675 663 - next: 664 676 cpuhp_lock_release(bringup); 665 677 666 678 if (!st->should_run) ··· 902 916 903 917 static void undo_cpu_down(unsigned int cpu, struct cpuhp_cpu_state *st) 904 918 { 905 - for (st->state++; st->state < st->target; st->state++) { 906 - struct cpuhp_step *step = cpuhp_get_step(st->state); 907 - 908 - if (!step->skip_onerr) 909 - cpuhp_invoke_callback(cpu, st->state, true, NULL, NULL); 910 - } 919 + for (st->state++; st->state < st->target; st->state++) 920 + cpuhp_invoke_callback(cpu, st->state, true, NULL, NULL); 911 921 } 912 922 913 923 static int cpuhp_down_callbacks(unsigned int cpu, struct cpuhp_cpu_state *st,