Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: sunxi: remove output of virtual base address

Recent Linux versions refuse to print actual virtual kernel addresses,
to not give a hint about the location of the kernel in a randomized virtual
address space. This affects the output of the sunxi MMC controller
driver, which now produces the rather uninformative line:

[ 1.482660] sunxi-mmc 1c0f000.mmc: base:0x(____ptrval____) irq:8

Since the virtual base address is not really interesting in the first
place, let's just drop this value. The same applies to Linux' notion of
the interrupt number, which is independent from the GIC SPI number.
We have the physical address as part of the DT node name, which is way
more useful for debugging purposes.
To keep a success message in the driver, we make this purpose explicit
with the word "initialized", plus print some information that is not too
obvious and that we learned while probing the device:
the maximum request size and whether it uses the new timing mode.
So the output turns into:
[ 1.750626] sunxi-mmc 1c0f000.mmc: initialized, max. request size: 16384 KB, uses new timings mode
[ 1.786699] sunxi-mmc 1c11000.mmc: initialized, max. request size: 2048 KB

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Andre Przywara and committed by
Ulf Hansson
1389690b 3cc89c12

+4 -1
+4 -1
drivers/mmc/host/sunxi-mmc.c
··· 1407 1407 if (ret) 1408 1408 goto error_free_dma; 1409 1409 1410 - dev_info(&pdev->dev, "base:0x%p irq:%u\n", host->reg_base, host->irq); 1410 + dev_info(&pdev->dev, "initialized, max. request size: %u KB%s\n", 1411 + mmc->max_req_size >> 10, 1412 + host->use_new_timings ? ", uses new timings mode" : ""); 1413 + 1411 1414 return 0; 1412 1415 1413 1416 error_free_dma: