Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK

AMS_ALARM_THR_DIRECT_MASK should be bit 0, not bit 1. This would cause
hysteresis to be enabled with a lower threshold of -28C. The temperature
alarm would never deassert even if the temperature dropped below the
upper threshold.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: O'Griofa, Conall <conall.ogriofa@amd.com>
Tested-by: Erim, Salih <Salih.Erim@amd.com>
Acked-by: Erim, Salih <Salih.Erim@amd.com>
Link: https://patch.msgid.link/20250715003058.2035656-1-sean.anderson@linux.dev
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Sean Anderson and committed by
Jonathan Cameron
1315cc2d feb500c7

+1 -1
+1 -1
drivers/iio/adc/xilinx-ams.c
··· 118 118 #define AMS_ALARM_THRESHOLD_OFF_10 0x10 119 119 #define AMS_ALARM_THRESHOLD_OFF_20 0x20 120 120 121 - #define AMS_ALARM_THR_DIRECT_MASK BIT(1) 121 + #define AMS_ALARM_THR_DIRECT_MASK BIT(0) 122 122 #define AMS_ALARM_THR_MIN 0x0000 123 123 #define AMS_ALARM_THR_MAX (BIT(16) - 1) 124 124