Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: msp3400: use semicolons rather than commas to separate statements

Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Julia Lawall and committed by
Mauro Carvalho Chehab
130e820d fa71ae71

+8 -4
+8 -4
drivers/media/i2c/msp3400-kthreads.c
··· 549 549 val = msp_read_dsp(client, 0x1b); 550 550 if (val > 32767) 551 551 val -= 65536; 552 - if (val1 < val) 553 - val1 = val, max1 = i; 552 + if (val1 < val) { 553 + val1 = val; 554 + max1 = i; 555 + } 554 556 dev_dbg_lvl(&client->dev, 1, msp_debug, 555 557 "carrier1 val: %5d / %s\n", val, cd[i].name); 556 558 } ··· 588 586 val = msp_read_dsp(client, 0x1b); 589 587 if (val > 32767) 590 588 val -= 65536; 591 - if (val2 < val) 592 - val2 = val, max2 = i; 589 + if (val2 < val) { 590 + val2 = val; 591 + max2 = i; 592 + } 593 593 dev_dbg_lvl(&client->dev, 1, msp_debug, 594 594 "carrier2 val: %5d / %s\n", val, cd[i].name); 595 595 }