Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

befs: fix style issues in header files

Fixing checkpatch.pl issues in befs header files:
WARNING: Missing a blank line after declarations
+ befs_inode_addr iaddr;
+ iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift;

WARNING: space prohibited between function name and open parenthesis '('
+ return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);

ERROR: "foo * bar" should be "foo *bar"
+ const char *key, befs_off_t * value);

ERROR: Macros with complex values should be enclosed in parentheses
+#define PACKED __attribute__ ((__packed__))

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

+12 -17
+2 -1
fs/befs/befs.h
··· 129 129 blockno2iaddr(struct super_block *sb, befs_blocknr_t blockno) 130 130 { 131 131 befs_inode_addr iaddr; 132 + 132 133 iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift; 133 134 iaddr.start = 134 135 blockno - (iaddr.allocation_group << BEFS_SB(sb)->ag_shift); ··· 141 140 static inline unsigned int 142 141 befs_iaddrs_per_block(struct super_block *sb) 143 142 { 144 - return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr); 143 + return BEFS_SB(sb)->block_size / sizeof(befs_disk_inode_addr); 145 144 } 146 145 147 146 #include "endian.h"
+4 -4
fs/befs/befs_fs_types.h
··· 55 55 }; 56 56 57 57 #define BEFS_BYTEORDER_NATIVE 0x42494745 58 - #define BEFS_BYTEORDER_NATIVE_LE (__force fs32)cpu_to_le32(BEFS_BYTEORDER_NATIVE) 59 - #define BEFS_BYTEORDER_NATIVE_BE (__force fs32)cpu_to_be32(BEFS_BYTEORDER_NATIVE) 58 + #define BEFS_BYTEORDER_NATIVE_LE ((__force fs32)cpu_to_le32(BEFS_BYTEORDER_NATIVE)) 59 + #define BEFS_BYTEORDER_NATIVE_BE ((__force fs32)cpu_to_be32(BEFS_BYTEORDER_NATIVE)) 60 60 61 61 #define BEFS_SUPER_MAGIC BEFS_SUPER_MAGIC1 62 - #define BEFS_SUPER_MAGIC1_LE (__force fs32)cpu_to_le32(BEFS_SUPER_MAGIC1) 63 - #define BEFS_SUPER_MAGIC1_BE (__force fs32)cpu_to_be32(BEFS_SUPER_MAGIC1) 62 + #define BEFS_SUPER_MAGIC1_LE ((__force fs32)cpu_to_le32(BEFS_SUPER_MAGIC1)) 63 + #define BEFS_SUPER_MAGIC1_BE ((__force fs32)cpu_to_be32(BEFS_SUPER_MAGIC1)) 64 64 65 65 /* 66 66 * Flags of inode
+2 -4
fs/befs/btree.h
··· 3 3 * 4 4 */ 5 5 6 - 7 6 int befs_btree_find(struct super_block *sb, const befs_data_stream *ds, 8 - const char *key, befs_off_t * value); 7 + const char *key, befs_off_t *value); 9 8 10 9 int befs_btree_read(struct super_block *sb, const befs_data_stream *ds, 11 10 loff_t key_no, size_t bufsize, char *keybuf, 12 - size_t * keysize, befs_off_t * value); 13 - 11 + size_t *keysize, befs_off_t *value);
+2 -3
fs/befs/datastream.h
··· 5 5 6 6 struct buffer_head *befs_read_datastream(struct super_block *sb, 7 7 const befs_data_stream *ds, 8 - befs_off_t pos, uint * off); 8 + befs_off_t pos, uint *off); 9 9 10 10 int befs_fblock2brun(struct super_block *sb, const befs_data_stream *data, 11 - befs_blocknr_t fblock, befs_block_run * run); 11 + befs_blocknr_t fblock, befs_block_run *run); 12 12 13 13 size_t befs_read_lsymlink(struct super_block *sb, const befs_data_stream *data, 14 14 void *buff, befs_off_t len); ··· 17 17 const befs_data_stream *ds); 18 18 19 19 extern const befs_inode_addr BAD_IADDR; 20 -
+1 -2
fs/befs/inode.h
··· 3 3 * 4 4 */ 5 5 6 - int befs_check_inode(struct super_block *sb, befs_inode * raw_inode, 6 + int befs_check_inode(struct super_block *sb, befs_inode *raw_inode, 7 7 befs_blocknr_t inode); 8 -
+1 -3
fs/befs/super.h
··· 2 2 * super.h 3 3 */ 4 4 5 - int befs_load_sb(struct super_block *sb, befs_super_block * disk_sb); 6 - 5 + int befs_load_sb(struct super_block *sb, befs_super_block *disk_sb); 7 6 int befs_check_sb(struct super_block *sb); 8 -