Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees()

audit_trim_trees() calls get_tree(). If a failure occurs we must call
put_tree().

[akpm@linux-foundation.org: run put_tree() before mutex_lock() for small scalability improvement]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Chen Gang and committed by
Linus Torvalds
12b2f117 373e0f34

+1 -1
+1 -1
kernel/audit_tree.c
··· 617 617 } 618 618 spin_unlock(&hash_lock); 619 619 trim_marked(tree); 620 - put_tree(tree); 621 620 drop_collected_mounts(root_mnt); 622 621 skip_it: 622 + put_tree(tree); 623 623 mutex_lock(&audit_filter_mutex); 624 624 } 625 625 list_del(&cursor);