Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: novatek-nt35560: Fix invalid return value

Fix bug in nt35560_set_brightness() which causes the function to
erroneously report an error. mipi_dsi_dcs_write() returns either a
negative value when an error occurred or a positive number of bytes
written when no error occurred. The buggy code reports an error under
either condition.

Fixes: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250731032343.1258366-2-me@brighamcampbell.com

authored by

Brigham Campbell and committed by
Neil Armstrong
125459e1 fdb4e289

+1 -1
+1 -1
drivers/gpu/drm/panel/panel-novatek-nt35560.c
··· 161 161 par = 0x00; 162 162 ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 163 163 &par, 1); 164 - if (ret) { 164 + if (ret < 0) { 165 165 dev_err(nt->dev, "failed to disable display backlight (%d)\n", ret); 166 166 return ret; 167 167 }