Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tests: Skip data symbol test if buf1 symbol is missing

perf data symbol test depends on finding symbol buf1 in perf, and fails if
perf has been stripped and no debug object is available. In that case, skip
the test instead.

Example:

Before:

$ strip tools/perf/perf
$ tools/perf/perf buildid-cache -p `realpath tools/perf/perf`
$ tools/perf/perf test -v 'data symbol'
113: Test data symbol :
--- start ---
test child forked, pid 125646
Recording workload...
[ perf record: Woken up 3 times to write data ]
[ perf record: Captured and wrote 0.577 MB /tmp/__perf_test.perf.data.Jhbdp (7794 samples) ]
Cleaning up files...
test child finished with -1
---- end ----
Test data symbol: FAILED!

After:

$ tools/perf/perf test -v 'data symbol'
113: Test data symbol :
--- start ---
test child forked, pid 125747
perf does not have symbol 'buf1'
perf is missing symbols - skipping test
test child finished with -2
---- end ----
Test data symbol: Skip

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20231123075848.9652-9-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Adrian Hunter and committed by
Arnaldo Carvalho de Melo
124bf636 3b24b15c

+5
+5
tools/perf/tests/shell/test_data_symbol.sh
··· 8 8 # shellcheck source=lib/waiting.sh 9 9 . "${shelldir}"/lib/waiting.sh 10 10 11 + # shellcheck source=lib/perf_has_symbol.sh 12 + . "${shelldir}"/lib/perf_has_symbol.sh 13 + 11 14 skip_if_no_mem_event() { 12 15 perf mem record -e list 2>&1 | grep -E -q 'available' && return 0 13 16 return 2 14 17 } 15 18 16 19 skip_if_no_mem_event || exit 2 20 + 21 + skip_test_missing_symbol buf1 17 22 18 23 TEST_PROGRAM="perf test -w datasym" 19 24 PERF_DATA=$(mktemp /tmp/__perf_test.perf.data.XXXXX)