Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Merge tag 'fpga-late-fixes-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga into char-misc-linus

Moritz writes:

FPGA manager fixes for 5.8

Here are two (late) dfl fixes for the the 5.8 release.

Matthew's fix addresses an issue in the reset of a port.

Xu'x fix addresses a linter warning.

All patches have been reviewed on the mailing list, and have been in the
last few linux-next releases (as part of my fixes branch) without issues.

Signed-off-by: Moritz Fischer <mdf@kernel.org>

* tag 'fpga-late-fixes-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga:
fpga: dfl: fix bug in port reset handshake
fpga: dfl: pci: reduce the scope of variable 'ret'

+4 -2
+2 -1
drivers/fpga/dfl-afu-main.c
··· 83 83 * on this port and minimum soft reset pulse width has elapsed. 84 84 * Driver polls port_soft_reset_ack to determine if reset done by HW. 85 85 */ 86 - if (readq_poll_timeout(base + PORT_HDR_CTRL, v, v & PORT_CTRL_SFTRST, 86 + if (readq_poll_timeout(base + PORT_HDR_CTRL, v, 87 + v & PORT_CTRL_SFTRST_ACK, 87 88 RST_POLL_INVL, RST_POLL_TIMEOUT)) { 88 89 dev_err(&pdev->dev, "timeout, fail to reset device\n"); 89 90 return -ETIMEDOUT;
+2 -1
drivers/fpga/dfl-pci.c
··· 227 227 { 228 228 struct cci_drvdata *drvdata = pci_get_drvdata(pcidev); 229 229 struct dfl_fpga_cdev *cdev = drvdata->cdev; 230 - int ret = 0; 231 230 232 231 if (!num_vfs) { 233 232 /* ··· 238 239 dfl_fpga_cdev_config_ports_pf(cdev); 239 240 240 241 } else { 242 + int ret; 243 + 241 244 /* 242 245 * before enable SRIOV, put released ports into VF access mode 243 246 * first of all.