Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
IB/mthca: Remove checks for srq->first_free < 0
The SRQ receive posting functions make sure that srq->first_free never
becomes negative, so we can remove tests of whether it is negative.
Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
authored by Eli Cohen and committed by Roland Dreier 1203c42e 1d96354e
+3
-23
drivers/infiniband/hw/mthca/mthca_srq.c
+3
-23
drivers/infiniband/hw/mthca/mthca_srq.c
···
475
476
spin_lock(&srq->lock);
477
478
-
if (likely(srq->first_free >= 0))
479
-
*wqe_to_link(get_wqe(srq, srq->last_free)) = ind;
480
-
else
481
-
srq->first_free = ind;
482
-
483
*wqe_to_link(get_wqe(srq, ind)) = -1;
484
srq->last_free = ind;
485
···
502
first_ind = srq->first_free;
503
504
for (nreq = 0; wr; wr = wr->next) {
505
-
ind = srq->first_free;
506
-
507
-
if (unlikely(ind < 0)) {
508
-
mthca_err(dev, "SRQ %06x full\n", srq->srqn);
509
-
err = -ENOMEM;
510
-
*bad_wr = wr;
511
-
break;
512
-
}
513
-
514
wqe = get_wqe(srq, ind);
515
next_ind = *wqe_to_link(wqe);
516
···
602
spin_lock_irqsave(&srq->lock, flags);
603
604
for (nreq = 0; wr; ++nreq, wr = wr->next) {
605
-
ind = srq->first_free;
606
-
607
-
if (unlikely(ind < 0)) {
608
-
mthca_err(dev, "SRQ %06x full\n", srq->srqn);
609
-
err = -ENOMEM;
610
-
*bad_wr = wr;
611
-
break;
612
-
}
613
-
614
wqe = get_wqe(srq, ind);
615
next_ind = *wqe_to_link(wqe);
616
···
475
476
spin_lock(&srq->lock);
477
478
+
*wqe_to_link(get_wqe(srq, srq->last_free)) = ind;
479
*wqe_to_link(get_wqe(srq, ind)) = -1;
480
srq->last_free = ind;
481
···
506
first_ind = srq->first_free;
507
508
for (nreq = 0; wr; wr = wr->next) {
509
+
ind = srq->first_free;
510
wqe = get_wqe(srq, ind);
511
next_ind = *wqe_to_link(wqe);
512
···
614
spin_lock_irqsave(&srq->lock, flags);
615
616
for (nreq = 0; wr; ++nreq, wr = wr->next) {
617
+
ind = srq->first_free;
618
wqe = get_wqe(srq, ind);
619
next_ind = *wqe_to_link(wqe);
620