Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: riscv,cpu-intc: Cleanups from a missed review

I managed to miss one of Rob's code reviews on the mailing list
<http://lists.infradead.org/pipermail/linux-riscv/2018-August/001139.html>.
The patch has already been merged, so I'm submitting a fixup.

Sorry!

Fixes: b67bc7cb4088 ("dt-bindings: interrupt-controller: RISC-V local interrupt controller")
Cc: Rob Herring <robh@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Karsten Merker <merker@debian.org>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>

+11 -3
+11 -3
Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt
··· 11 11 attached to every HLIC: software interrupts, the timer interrupt, and external 12 12 interrupts. Software interrupts are used to send IPIs between cores. The 13 13 timer interrupt comes from an architecturally mandated real-time timer that is 14 - controller via Supervisor Binary Interface (SBI) calls and CSR reads. External 14 + controlled via Supervisor Binary Interface (SBI) calls and CSR reads. External 15 15 interrupts connect all other device interrupts to the HLIC, which are routed 16 16 via the platform-level interrupt controller (PLIC). 17 17 ··· 25 25 26 26 Required properties: 27 27 - compatible : "riscv,cpu-intc" 28 - - #interrupt-cells : should be <1> 28 + - #interrupt-cells : should be <1>. The interrupt sources are defined by the 29 + RISC-V supervisor ISA manual, with only the following three interrupts being 30 + defined for supervisor mode: 31 + - Source 1 is the supervisor software interrupt, which can be sent by an SBI 32 + call and is reserved for use by software. 33 + - Source 5 is the supervisor timer interrupt, which can be configured by 34 + SBI calls and implements a one-shot timer. 35 + - Source 9 is the supervisor external interrupt, which chains to all other 36 + device interrupts. 29 37 - interrupt-controller : Identifies the node as an interrupt controller 30 38 31 39 Furthermore, this interrupt-controller MUST be embedded inside the cpu ··· 46 38 ... 47 39 cpu1-intc: interrupt-controller { 48 40 #interrupt-cells = <1>; 49 - compatible = "riscv,cpu-intc", "sifive,fu540-c000-cpu-intc"; 41 + compatible = "sifive,fu540-c000-cpu-intc", "riscv,cpu-intc"; 50 42 interrupt-controller; 51 43 }; 52 44 };