Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: tps65219: regulator: tps65219: Fix error codes in probe()

There is a copy and paste error and we accidentally use "PTR_ERR(rdev)"
instead of "error". The "rdev" pointer is valid at this point.

Also there is no need to print the error code in the error message
because dev_err_probe() already prints that. So clean up the error
message a bit.

Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKRGmVdbvT1HBvm8@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Dan Carpenter and committed by
Mark Brown
11cd7a5c 447be505

+6 -6
+6 -6
drivers/regulator/tps65219-regulator.c
··· 454 454 irq_type->irq_name, 455 455 irq_data); 456 456 if (error) 457 - return dev_err_probe(tps->dev, PTR_ERR(rdev), 458 - "Failed to request %s IRQ %d: %d\n", 459 - irq_type->irq_name, irq, error); 457 + return dev_err_probe(tps->dev, error, 458 + "Failed to request %s IRQ %d\n", 459 + irq_type->irq_name, irq); 460 460 } 461 461 462 462 for (i = 0; i < pmic->dev_irq_size; ++i) { ··· 477 477 irq_type->irq_name, 478 478 irq_data); 479 479 if (error) 480 - return dev_err_probe(tps->dev, PTR_ERR(rdev), 481 - "Failed to request %s IRQ %d: %d\n", 482 - irq_type->irq_name, irq, error); 480 + return dev_err_probe(tps->dev, error, 481 + "Failed to request %s IRQ %d\n", 482 + irq_type->irq_name, irq); 483 483 } 484 484 485 485 return 0;