Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/xe: Remove extra dma_fence_put on xe_sync_entry_add_deps failure

drm_sched_job_add_dependency() drops references even in case of error,
no need for caller to call dma_fence_put.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240820090230.3258128-1-himal.prasad.ghimiray@intel.com
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>

authored by

Himal Prasad Ghimiray and committed by
Nirmoy Das
11b7309d 9c57bc08

+3 -10
+3 -10
drivers/gpu/drm/xe/xe_sync.c
··· 206 206 207 207 int xe_sync_entry_add_deps(struct xe_sync_entry *sync, struct xe_sched_job *job) 208 208 { 209 - int err; 210 - 211 - if (sync->fence) { 212 - err = drm_sched_job_add_dependency(&job->drm, 213 - dma_fence_get(sync->fence)); 214 - if (err) { 215 - dma_fence_put(sync->fence); 216 - return err; 217 - } 218 - } 209 + if (sync->fence) 210 + return drm_sched_job_add_dependency(&job->drm, 211 + dma_fence_get(sync->fence)); 219 212 220 213 return 0; 221 214 }