Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware: raspberrypi: Use dev_err_probe() to simplify code

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20220924025041.29389-1-yuancan@huawei.com
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

authored by

Yuan Can and committed by
Florian Fainelli
117bd98d 9abf2313

+3 -6
+3 -6
drivers/firmware/raspberrypi.c
··· 268 268 fw->cl.tx_block = true; 269 269 270 270 fw->chan = mbox_request_channel(&fw->cl, 0); 271 - if (IS_ERR(fw->chan)) { 272 - int ret = PTR_ERR(fw->chan); 273 - if (ret != -EPROBE_DEFER) 274 - dev_err(dev, "Failed to get mbox channel: %d\n", ret); 275 - return ret; 276 - } 271 + if (IS_ERR(fw->chan)) 272 + return dev_err_probe(dev, PTR_ERR(fw->chan), 273 + "Failed to get mbox channel\n"); 277 274 278 275 init_completion(&fw->c); 279 276 kref_init(&fw->consumers);