Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware: google: test spinlock on panic path to avoid lockups

Currently the gsmi driver registers a panic notifier as well as reboot and
die notifiers. The callbacks registered are called in atomic and very
limited context - for instance, panic disables preemption and local IRQs,
also all secondary CPUs (not executing the panic path) are shutdown.

With that said, taking a spinlock in this scenario is a dangerous
invitation for lockup scenarios. So, fix that by checking if the spinlock
is free to acquire in the panic notifier callback - if not, bail-out and
avoid a potential hang.

Link: https://lkml.kernel.org/r/20220909200755.189679-1-gpiccoli@igalia.com
Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Reviewed-by: Evan Green <evgreen@chromium.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: David Gow <davidgow@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Guilherme G. Piccoli and committed by
Andrew Morton
1179083f 5758478a

+9
+9
drivers/firmware/google/gsmi.c
··· 681 681 static int gsmi_panic_callback(struct notifier_block *nb, 682 682 unsigned long reason, void *arg) 683 683 { 684 + 685 + /* 686 + * Panic callbacks are executed with all other CPUs stopped, 687 + * so we must not attempt to spin waiting for gsmi_dev.lock 688 + * to be released. 689 + */ 690 + if (spin_is_locked(&gsmi_dev.lock)) 691 + return NOTIFY_DONE; 692 + 684 693 gsmi_shutdown_reason(GSMI_SHUTDOWN_PANIC); 685 694 return NOTIFY_DONE; 686 695 }